Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1111786 into lp:zorba

2013-02-08 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-786/+merge/147020 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1111786 into lp:zorba

2013-02-08 Thread Matthias Brantner
Review: Needs Fixing The code is good. However, the documentation of the variables should be added to doc/zorba/errors_warnings.dox (there is already a section that describes other available variables). -- https://code.launchpad.net/~zorba-coders/zorba/bug-786/+merge/147020 Your team Zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1111786 into lp:zorba

2013-02-07 Thread Matthias Brantner
I think we can make this a separate item. On Feb 7, 2013, at 6:35 AM, Paul J. Lucas wrote: > Do I have to add the file-name to streamable strings for this? > -- > https://code.launchpad.net/~zorba-coders/zorba/bug-786/+merge/147020 > You are reviewing the proposed merge of lp:~zorba-coders/

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1111786 into lp:zorba

2013-02-07 Thread Paul J. Lucas
Do I have to add the file-name to streamable strings for this? -- https://code.launchpad.net/~zorba-coders/zorba/bug-786/+merge/147020 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1111786 into lp:zorba

2013-02-06 Thread Matthias Brantner
Review: Needs Fixing There are no tests -- https://code.launchpad.net/~zorba-coders/zorba/bug-786/+merge/147020 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1111786 into lp:zorba

2013-02-06 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 1 Approve. -- https://code.launchpad.net/~zorba-coders/zorba/bug-786/+merge/147020 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1111786 into lp:zorba

2013-02-06 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-786/+merge/147020 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co