Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188035-csv into lp:zorba/csv-module

2013-08-28 Thread Paul J. Lucas 
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655
Your team Zorba Coders is subscribed to branch lp:zorba/csv-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188035-csv into lp:zorba/csv-module

2013-08-28 Thread Matthias Brantner 
Review: Needs Fixing

- use p/P tags between paragraphs
- use pre for blocks of code (e.g. for $options in csv:parse#2)
- the namespace of the nodes that are created by the parse function is still 
http://www.zorba-xquery...; (e.g. test7:row 
xmlns:test7=http://www.zorba-xquery/modules/csv;)
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655
Your team Zorba Coders is subscribed to branch lp:zorba/csv-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188035-csv into lp:zorba/csv-module

2013-08-28 Thread Paul J. Lucas 
 - use p/P tags between paragraphs
 - use pre for blocks of code (e.g. for $options in csv:parse#2)
 - the namespace of the nodes that are created by the parse function is still
 http://www.zorba-xquery...; (e.g. test7:row xmlns:test7=http://www.zorba-
 xquery/modules/csv)

Done.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655
Your team Zorba Coders is subscribed to branch lp:zorba/csv-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1188035-csv into lp:zorba/csv-module

2013-08-28 Thread Matthias Brantner 
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1188035-csv/+merge/182655
Your team Zorba Coders is subscribed to branch lp:zorba/csv-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp