Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba

2012-05-03 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: text conflict in src/store/naive/simple_pul.cpp -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba

2012-05-02 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba

2012-05-02 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: text conflict in src/store/naive/simple_pul.cpp -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba

2012-04-27 Thread Markos Zaharioudakis
This is ready for review again. -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba

2012-04-27 Thread Matthias Brantner
Review: Approve Looks good. I have disabled some debug output in rev. 10748. -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba

2012-04-27 Thread Till Westmann
Review: Approve It would be nice to have 2 comments explaining 1) the modification of the parameter in simple_index_value.cpp:380 and 674 and 2) the role of key2 in Store::populateValueIndex. It would also be nice to use the typedef here: === modified file 'src/store/naive/simple_pul.cpp' ---

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba

2012-04-25 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba

2012-04-25 Thread Matthias Brantner
Review: Needs Fixing It seems that automatic indexes are not maintained if a node is deleted. The following example shows this: library module: module namespace seq = http://www.foo.com/default;;

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba

2012-04-25 Thread Markos Zaharioudakis
I have fixed your test, but now I have a problem with test index/undo3.xq. Its result is non-deterministic. Most of the time it returns the correct result, but sometimes not. And valgrind does not show any errors :( -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba

2012-04-23 Thread Markos Zaharioudakis
I have implemented undo for incrementally maintained indexes. -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba

2012-04-23 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 2 Approve, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba

2012-04-11 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: text conflict in ChangeLog -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba

2012-04-11 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 3 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-966706 into lp:zorba

2012-04-11 Thread Markos Zaharioudakis
Review: Needs Fixing The problem is that now an index refresh must be undoable. I am looking at the code to think wat is the best way to do the undo. -- https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing