Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98891
Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://lau
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1,
Needs Fixing < 1, Pending < 1. Got: 2 Approve, 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98891
Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module.
--
M
Review: Approve
Yay for removing unnecessary CMake flags! Looks good.
--
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98891
Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba
Review: Approve
Looks good.
--
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98891
Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
ZORBA_WITH_FOP flag has been eliminated...
--
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98891
Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Sounds fine with me. So remove the ZORBA_WITH_FOP all together and work around
cmake bugs.
--
https://code.launchpad.net/~zorba-coders/zorba/bug955040/+merge/98891
Your team Zorba Coders is subscribed to branch lp:zorba/data-formatting-module.
--
Mailing list: https://launchpad.net/~zorba-coder
Review: Needs Fixing
I don't understand what ZORBA_WITH_FOP means at all. I'm not really a fan of
having flags to enable functionality anyway, at least not in non-core module
packages - if the user took the time to download the package, presumably they
want the contents, so why force them to ad
Review: Needs Fixing
1. ZORBA_WITH_FOP means I really want FOP. Ie if there is anything missing it's
an error.
So if ZORBA_WITH_FOP and ZORBA_SUPPRESS_JAVA are both true should be an error.
2. Why did you replace 1 IF with AND condition with 8 nested IF's ?
--
https://code.launchpad.net/~zorba-
8 matches
Mail list logo