Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-fn-path into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-fn-path/+merge/114922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-fn-path into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-fn-path/+merge/114922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-fn-path into lp:zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 3 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/fix-fn-path/+merge/114922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-fn-path into lp:zorba
Resubmitted proposal and added Matthias as reviewer. -- https://code.launchpad.net/~zorba-coders/zorba/fix-fn-path/+merge/114922 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-fn-path into lp:zorba
> Hi Till, I noticed after approving that the diff seems to replace the new > EQName syntax with the old one. Is this the intent? No, it isn't. Thanks! -- https://code.launchpad.net/~zorba-coders/zorba/fix-fn-path/+merge/114739 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-fn-path into lp:zorba
Review: Needs Fixing Hi Till, I noticed after approving that the diff seems to replace the new EQName syntax with the old one. Is this the intent? -- https://code.launchpad.net/~zorba-coders/zorba/fix-fn-path/+merge/114739 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-fn-path into lp:zorba
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-fn-path/+merge/114739 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-fn-path into lp:zorba
Review: Approve Till, did you really have a case where the "swap" local var was needed? I think I can see why it is needed, but I think the code in item_handle should be changed (call addReference() before remveReference()) to make "swap" unecessary. Do you agree? -- https://code.launchpad.net/~zorba-coders/zorba/fix-fn-path/+merge/114739 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-fn-path into lp:zorba
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 3 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/fix-fn-path/+merge/114739 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
