Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1123843 into lp:zorba

2013-02-20 Thread Markos Zaharioudakis 
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1123843/+merge/149344
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1123843 into lp:zorba

2013-02-19 Thread Sorin Marian Nasoi 
> Why do you need the second deep-equal? (the one that reverses $x)
It's a fix for test case "fn-distinct-values-mixed-args-011" from 
"fn-distinct-values":

[...]
fn:distinct-values((xs:decimal('1.2'), '1.2'))
[...]
"1.2", 1.2
[...]

The proposed fix thus covers all existing usage of 'assert-permutation', not 
all possible cases that may exist.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1123843/+merge/149344
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1123843 into lp:zorba

2013-02-19 Thread Markos Zaharioudakis 
Why do you need the second deep-equal? (the one that reverses $x)
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1123843/+merge/149344
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1123843 into lp:zorba

2013-02-19 Thread Zorba Build Bot 
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, 
Needs Fixing < 1, Pending < 1. Got: 1 Approve.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1123843/+merge/149344
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1123843 into lp:zorba

2013-02-19 Thread Zorba Build Bot 
The attempt to merge lp:~zorba-coders/zorba/fix_bug_1123843 into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job fix_bug_1123843-2013-02-19T17-13-41.282Z is finished.
  The final status was:

  

  6 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1123843/+merge/149344
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_1123843 into lp:zorba

2013-02-19 Thread Sorin Marian Nasoi 
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_1123843/+merge/149344
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp