Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_html_module into lp:zorba/data-converters-module
I think we should add an additional function declare function html:parse ( $html as xs:string, $options as element(html-options:options) ) as xs:string external; which returns the string processed by tidy. The other functions should invoke this function and call parse-xml on the result. This gives the user a way to see the result of tidy. -- https://code.launchpad.net/~zorba-coders/zorba/fix_html_module/+merge/106814 Your team Zorba Coders is subscribed to branch lp:zorba/data-converters-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_html_module into lp:zorba/data-converters-module
Review: Approve I have updated the information about the returned error codes: this is IMO the best thing if we want to keep the current function signatures (i.e. that return document-node() ). Alternatively we can change the signatures to return string and make the user call fn:parse-xml() explicitly. -- https://code.launchpad.net/~zorba-coders/zorba/fix_html_module/+merge/106814 Your team Zorba Coders is subscribed to branch lp:zorba/data-converters-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_html_module into lp:zorba/data-converters-module
Review: Needs Fixing - the error message is misleading because the query doesn't explicitly invoke parse-xml: :124,5: user-defined error [http://www.zorba-xquery.com/modules/converters/html#InternalError]: invalid content passed to fn:parse-xml(): loader parsing error: Failed to parse QName 'divine:' - it's still unclear to me how the user can find out how the result after parsing looked like. In this case, tidying succeeded but there is a problem with the result after tidying. - please don't use tabs -- https://code.launchpad.net/~zorba-coders/zorba/fix_html_module/+merge/106814 Your team Zorba Coders is subscribed to branch lp:zorba/data-converters-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_html_module into lp:zorba/data-converters-module
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_html_module/+merge/106814 Your team Zorba Coders is subscribed to branch lp:zorba/data-converters-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
