Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba

2012-02-23 Thread Till Westmann
Review: Approve include/zorba/item.h: Docs do not say what happens, if getBase64BinaryValue is called when the item is streamable. include/zorba/item_factory.h: whence isn't the most commonly used word (http://en.wiktionary.org/wiki/whence) maybe we could use another one

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba

2012-02-23 Thread Matthias Brantner
include/zorba/item.h: Docs do not say what happens, if getBase64BinaryValue is called when the item is streamable. fixed include/zorba/item_factory.h: whence isn't the most commonly used word (http://en.wiktionary.org/wiki/whence) maybe we could use another one fixed (although the comment

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba

2012-02-23 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/ft-base64Binary/+merge/94494 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba

2012-02-23 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1. Got: 1 Approve, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/ft-base64Binary/+merge/94494 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba

2012-02-23 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/ft-base64Binary/+merge/94494 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba

2012-02-22 Thread Dennis Knochenwefel
this also fixes bug #933490 -- https://code.launchpad.net/~zorba-coders/zorba/ft-base64Binary/+merge/94081 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba

2012-02-21 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job ft-base64Binary-2012-02-22T01-41-08.742Z is finished.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba

2012-02-21 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/ft-base64Binary/+merge/94081 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/ft-base64Binary into lp:zorba

2012-02-21 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1. Got: 1 Approve, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/ft-base64Binary/+merge/94081 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders