Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-09-11 Thread Ghislain Fourny
Review: Approve

LGTM
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-09-06 Thread Ghislain Fourny
Thanks Nicolae!

The following does not seem to work:

jsoniq version 1.0;

variable $a := [];

insert (1, 2) into $a at position 1;

$a

It might be because insert(1, 2) is parsed as a function call. Would it be 
possible to resolve the conflict using the lookahead (whether into is here or 
not)?
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-09-05 Thread Nicolae Brinza
Ghislain, I've fixed the null/true/false etc and select issues (points 5 and 
8). 

--
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-09-03 Thread Nicolae Brinza
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-09-03 Thread Ghislain Fourny
Review: Needs Fixing

Hi Nicolae,

Looks good, thanks ;-) It's getting closer and closer to the git EBNFs!

Here are some comments:

1. Parser.y, line 2259: is || (block != NULL  block-isEmpty()) really 
needed? Will block not always be null if a BlockExpr is {} (see 
StatementsAndOptionalExpr nonterminal)?

2. Why is the OBJECT token treated specially and not mentioned in 
GeneralizedAtomicType like array/item/structured-item? Note that jn:object is 
no longer a function, as it was removed (I thought Markos removed it from 
Zorba, too). Then object should also be moved back to invalid function names.

Suggested test: object() throws a parsing error.

3. VersionDecl should not allow xquery in the JSONiq parser. Now, it seems to 
be allowed. A JSONiq query version declaration must be jsoniq (if a file 
begins with xquery the XQuery parser will be used anyway, so there is no way 
to test).

4. Why is append not authorized as a function? I thought it would be together 
with insert/rename/replace/delete.

Suggested test: local definition for local:append + default function namespace 
and query append().

5. From instead of For is implemented, but where is select instead of 
return? (this might require discussion about getting rid of from, actually. 
I am not sure if the from/select decision was not reverted at some point.)

Suggested test: from $i in 1 to 10 select $i

6. Can you give me details and examples about the two new conflicts?

7. How is [[]] array handled? Is it parsed as a predicate with an array 
constructor and handled in the translator?

8. TRUE/FALSE/NULL/FROM(/SELECT?) should appear in the FUNCTION_NAME rule in a 
JSONIQ_PARSER #ifdef so that they can be used as function names. Or is this 
handled somewhere else?

Suggested test: false(), true(), null() -- from() with a local definition (see 
append above).

I hope it makes sense? Thanks!
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-09-03 Thread Nicolae Brinza
 1. Parser.y, line 2259: is || (block != NULL  block-isEmpty()) really
 needed? Will block not always be null if a BlockExpr is {} (see
 StatementsAndOptionalExpr nonterminal)?

Nope, you can have a nested empty block {{}}.


 2. Why is the OBJECT token treated specially and not mentioned in
 GeneralizedAtomicType like array/item/structured-item? Note that jn:object is
 no longer a function, as it was removed (I thought Markos removed it from
 Zorba, too). Then object should also be moved back to invalid function names.
 Suggested test: object() throws a parsing error.

I was not aware the function was removed. I've moved the token.


 3. VersionDecl should not allow xquery in the JSONiq parser. Now, it seems to
 be allowed. A JSONiq query version declaration must be jsoniq (if a file
 begins with xquery the XQuery parser will be used anyway, so there is no way
 to test).

Yes, it makes sense. Fixed. 

 4. Why is append not authorized as a function? I thought it would be together
 with insert/rename/replace/delete.
 
 Suggested test: local definition for local:append + default function namespace
 and query append().

Fixed, but the function call can only be made through the prefixed form, 
because in jsoniq you can have:
append () into ...


 5. From instead of For is implemented, but where is select instead of
 return? (this might require discussion about getting rid of from,
 actually. I am not sure if the from/select decision was not reverted at some
 point.)
 Suggested test: from $i in 1 to 10 select $i

select is handled in the scanner. There already are plenty of tests in 
zorba/jsoniq. Though I think select handling should be moved from the scanner 
to the parser if we are to allow it as a qname/function name.


 6. Can you give me details and examples about the two new conflicts?

Which two new conflicts? The conflicts count has not changed. 

 7. How is [[]] array handled? Is it parsed as a predicate with an array
 constructor and handled in the translator?

Is it actually handled? Quite interestingly this:

  let $var := [[1, 2, 3]]
  return $var[[]]

segfaults in the current trunk. 

 8. TRUE/FALSE/NULL/FROM(/SELECT?) should appear in the FUNCTION_NAME rule in a
 JSONIQ_PARSER #ifdef so that they can be used as function names. Or is this
 handled somewhere else?
 Suggested test: false(), true(), null() -- from() with a local definition (see
 append above).

It is not possible to add them to the qnames because they would completely 
interfere with the path expressions. One way to go around it would be to remove 
the keywords from the Literals production and then check the value of the 
RelativePathExprs in the rule action. It might work, but I would have to test 
it.


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/183640
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-11 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-10 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: 

text conflict in ChangeLog
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-10 Thread Nicolae Brinza
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-10 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:281 
(message):
  Validation queue job new-jsoniq-2013-06-10T15-23-50.144Z is finished.  The
  final status was:

  

  1 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-10 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1, Needs Information  1, Resubmit  1. Got: 1 
Approve, 1 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/168471
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-07 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:281 
(message):
  Validation queue job new-jsoniq-2013-06-07T08-07-50.452Z is finished.  The
  final status was:

  

  2 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167907
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-06 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:281 
(message):
  Validation queue job new-jsoniq-2013-06-06T18-12-45.616Z is finished.  The
  final status was:

  

  No tests were run - build or configure step must have failed.

  Not commiting changes.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-06 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:281 
(message):
  Validation queue job new-jsoniq-2013-06-06T19-02-00.114Z is finished.  The
  final status was:

  

  2 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-06-06 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1, Needs Information  1, Resubmit  1. Got: 1 
Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/167824
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Ghislain Fourny
   Why would you need a qualified value if the option itself is already
  qualified?
 
  I guess because the option name and the option value may not live in the
 same
  namespace.
 
 Why not? It's not as if you do schema validation on the options and their
 values. The option needs to be qualified to distinguish it from XQuery
 options, but the value needs not. And the validation is done entirely in the
 code so there is no schema validation.

Technically, it is up to us - does the op:enable option accept QName or string 
values? If it is strings, I agree. If it is QNames, the namespace is important 
I think.

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Ghislain Fourny
Review: Needs Fixing

I can not see any warning if a version declaration is present. Was it fixed? Am 
I doing something wrong?

jsoniq version 1.0;
declare namespace op = http://www.zorba-xquery.com/options/features;;
declare option op:enable common-language;
{ foo : bar }

- no warning for me.

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Chris Hillery
Ghislain - it seems to work if you specify the option on the command line:

% zorba --option 
'{http://www.zorba-xquery.com/options/features}enable=common-language' -q 
'jsoniq version 1.0; { foo : bar }'
.:1,2: Zorba static warning [zwarn:ZWST0009]: feature not supported by the 
common language grammar: version declaration; raised at 
/home/ceej/zo/src/src/compiler/translator/translator.cpp:2495
{ foo : bar }

It kind of makes sense to me that declaring the option inside the query itself 
doesn't retro-actively jump back and ensure that you didn't do anything bad 
before the option itself was parsed.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Ghislain Fourny
Review: Approve

Approving because the last open issue is not release-critical.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Ghislain Fourny
Your comment makes a lot of sense too, thanks!

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Nicolae Brinza
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1, Needs Information  1, Resubmit  1. Got: 2 
Approve, 1 Needs Fixing.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Ghislain Fourny
Thanks Nicolae, this is perfect now.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Matthias Brantner
Review: Approve

The commit could add something to the ChangeLog. Otherwise I'm also happy.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Nicolae Brinza
I've added a mention in the ChangeLog
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Nicolae Brinza
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Ghislain Fourny
Pending approval and merge of null-type-fix before sending to the trunk.

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Nicolae Brinza
Done
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Nicolae Brinza
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Ghislain Fourny
The parser must be regenerated I think.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job new-jsoniq-2013-05-15T16-11-04.9Z is finished.  The
  final status was:

  

  1 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-15 Thread Nicolae Brinza
Yeah, I just fixed that unit test as well...
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-13 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job new-jsoniq-2013-05-13T11-36-28.819Z is finished.  The
  final status was:

  

  1 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-13 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1, Needs Information  1, Resubmit  1. Got: 1 
Approve, 2 Needs Fixing.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-13 Thread Nicolae Brinza
Matthias, your suggestions for two improved warnings do not change the 
messages: you just switched the order of the words. The warnings are built 
around the template: 

feature not supported by the common language grammar{: $1}

So it is not easy to make this swap. I could probably do it, but then I would 
have to change all the other messages. Do you think it is worth it?

Other than that, I have fixed all of the issues raised by you and Ghislain. 

There has been a confusion which resulted in many warnings not working for you 
and Ghislain even though they were implemented. The problem was that you both 
used a qualified string for the op:enable option, i.e. you used 
f:common-language. Why would you need a qualified value if the option itself 
is already qualified?

As we discussed, it is not possible to resolve a prefix during the Bison 
parsing, and that is why the initial code did not allow for a prefix in the 
value. I have changed it, and now it allows a prefix but it will be ignored 
during the parsing. 


--


 1. improve warning messages:
 
 feature not supported by the common language grammar: JSONiq dot object lookup
 =
 jsoniq dot object lookup not supported by common language
 
 
 feature not supported by the common language grammar: context item expression;
 use zorba-util:context-item()
 =
 context item expression not supported by common language (use util:context-
 item() instead)
 
 2. Query doesn't raise a warning:
 jsoniq version 1.0;
 
 declare namespace op = http://www.zorba-xquery.com/options/features;;
 declare namespace f = http://www.zorba-xquery.com/features;;
 
 declare option op:enable f:common-language;
 
 {}
 
 3. Query without version declaration doesn't raise a warning
 
 4. Query returns warning with wrong warning location, i.e. 8,13
 
 jsoniq version 1.0;
 
 declare namespace op = http://www.zorba-xquery.com/options/features;;
 declare namespace f = http://www.zorba-xquery.com/features;;
 
 declare option op:enable f:common-language;
 
 let $foo := { f.oo : bar }.f.oo
 return $foo
 
 /home/mbrantner/zorba/build/tmp.xq:8,13: Zorba static warning
 [zwarn:ZWST0009]: feature not supported by the common language grammar: JSONiq
 dot object lookup
 /home/mbrantner/zorba/build/tmp.xq:8,13: Zorba static warning
 [zwarn:ZWST0009]: feature not supported by the common language grammar: JSONiq
 dot object lookup
 
 5. The following query doesn't raise a warning
 
 xquery version 1.0;
 
 declare namespace op = http://www.zorba-xquery.com/options/features;;
 declare namespace f = http://www.zorba-xquery.com/features;;
 
 declare option op:enable f:common-language;
 
 let $foo := 'foo'
 return $foo
 
 6. The following query doesn't raise a warning
 
 jsoniq version 1.0;
 
 declare namespace op = http://www.zorba-xquery.com/options/features;;
 declare namespace f = http://www.zorba-xquery.com/features;;
 
 declare option op:enable f:common-language;
 
 let $foo := { foo : bar }
 return insert { bar : 42 } into $foo;
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-13 Thread Ghislain Fourny
 Why would you need a qualified value if the option itself is already 
 qualified?

I guess because the option name and the option value may not live in the same 
namespace.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-13 Thread Nicolae Brinza
  Why would you need a qualified value if the option itself is already
 qualified?
 
 I guess because the option name and the option value may not live in the same
 namespace.

Why not? It's not as if you do schema validation on the options and their 
values. The option needs to be qualified to distinguish it from XQuery options, 
but the value needs not. And the validation is done entirely in the code so 
there is no schema validation.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-13 Thread Ghislain Fourny
Review: Needs Fixing

Thanks for fixing the warnings. I successfully checked, except for two things:

1.

\ (XQuery parser) or  (JSONiq parser) leads to a warning about disallowed 
character entity references/JSON character escape sequence. I think the warning 
could be made more general and say that XML character and entity references, 
JSON backslash escapes, as well as standalone ampersands and backslashes are 
not allowed.

(by the way, character entity references do not exist in XML. There are 
character references (#...;) and entity references (...;), but not both at 
the same time if I am correct :-) )

2.

afoo//a/(foo)

(in the XQuery parser) does not seem to be caught with a warning.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-13 Thread Nicolae Brinza
 (by the way, character entity references do not exist in XML. There are
 character references (#...;) and entity references (...;), but not both at
 the same time if I am correct :-) )

Indeed you're right. I trusted Wikipedia which uses the term character entity 
references and says ``The XML specification does not use the term character 
entity or character entity reference. '' -- 
http://en.wikipedia.org/wiki/Character_entity_reference#Predefined_entities_in_XML
 . I've checked now the XML spec and it does seem to have the definitions: 
http://www.w3.org/TR/xml/#sec-references .

I'll change the messages to what you suggested, but I'll keep both of them -- 
it is much better to have them as customized as possible.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-13 Thread Nicolae Brinza
Fixed all the raised issues.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-10 Thread Ghislain Fourny
Review: Needs Fixing

It looks good on the whole. For convenience, I am pasting the list of the 
findings I sent to the zorba-dev mailing list, as of revision 11342 of this 
branch, here:

- The dot context item should be a syntax error in the JSONiq parser, but { 
foo : bar } ! . seems to parse fine.
- No error is thrown when beginning a path expression with an axis step in the 
JSONiq parser, e.g. afoo//a/(foo) (mind the parentheses, i.e., foo does 
begin a path expression) should not parse with JSONiq.


- Use of \ or  in literals in the common language (both parsers) does not seem 
to raise warnings. 
- Use of {} in the common language (both parsers) does not seem to raise 
warnings.
- Use of true/false/null literals in the common language (JSONiq parser) does 
not seem to raise warnings.
- Use of () for the empty sequence type syntax in the common language (JSONiq 
parser) does not seem to raise warnings.
- Use of simplified update syntax (no json) in the common language (JSONiq 
parser) does not seem to raise warnings.
- Use of single-quoted literals in the common language (XQuery parser) does not 
seem to raise warnings.
- Use of unquoted object keys in the common language (JSONiq parser) does not 
seem to raise warnings.
- Use of a path expression beginning with an axis step in the common language 
(XQuery parser) seems to raise the wrong warning (is : context item expression, 
should be : path expression may not begin with an axis step).
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-09 Thread Matthias Brantner
Review: Needs Fixing

1. improve warning messages:

feature not supported by the common language grammar: JSONiq dot object lookup
=
jsoniq dot object lookup not supported by common language


feature not supported by the common language grammar: context item expression; 
use zorba-util:context-item()
=
context item expression not supported by common language (use 
util:context-item() instead)

2. Query doesn't raise a warning:
jsoniq version 1.0;

declare namespace op = http://www.zorba-xquery.com/options/features;;
declare namespace f = http://www.zorba-xquery.com/features;;

declare option op:enable f:common-language;

{}

3. Query without version declaration doesn't raise a warning

4. Query returns warning with wrong warning location, i.e. 8,13

jsoniq version 1.0;

declare namespace op = http://www.zorba-xquery.com/options/features;;
declare namespace f = http://www.zorba-xquery.com/features;;

declare option op:enable f:common-language;

let $foo := { f.oo : bar }.f.oo
return $foo

/home/mbrantner/zorba/build/tmp.xq:8,13: Zorba static warning 
[zwarn:ZWST0009]: feature not supported by the common language grammar: JSONiq 
dot object lookup
/home/mbrantner/zorba/build/tmp.xq:8,13: Zorba static warning 
[zwarn:ZWST0009]: feature not supported by the common language grammar: JSONiq 
dot object lookup

5. The following query doesn't raise a warning

xquery version 1.0;

declare namespace op = http://www.zorba-xquery.com/options/features;;
declare namespace f = http://www.zorba-xquery.com/features;;

declare option op:enable f:common-language;

let $foo := 'foo'
return $foo

6. The following query doesn't raise a warning

jsoniq version 1.0;

declare namespace op = http://www.zorba-xquery.com/options/features;;
declare namespace f = http://www.zorba-xquery.com/features;;

declare option op:enable f:common-language;

let $foo := { foo : bar }
return insert { bar : 42 } into $foo;
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-03 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job new-jsoniq-2013-05-03T14-40-57.855Z is finished.  The
  final status was:

  

  3 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162362
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-03 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1, Needs Information  1, Resubmit  1. Got: 1 
Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/162375
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-05-01 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job new-jsoniq-2013-05-01T17-24-52.433Z is finished.  The
  final status was:

  

  No tests were run - build or configure step must have failed.

  Not commiting changes.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/161892
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-19 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159739
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-19 Thread Nicolae Brinza
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159739
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-19 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job new-jsoniq-2013-04-19T20-39-52.046Z is finished.  The
  final status was:

  

  5 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159739
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-19 Thread Nicolae Brinza
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159739
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-19 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job new-jsoniq-2013-04-19T21-18-54.417Z is finished.  The
  final status was:

  

  5 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159739
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-19 Thread Nicolae Brinza
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159739
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-19 Thread Nicolae Brinza
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159739
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-18 Thread Nicolae Brinza
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159736
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-18 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1, Needs Information  1, Resubmit  1. Got: 1 
Approve, 1 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159736
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-18 Thread Nicolae Brinza
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159739
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-18 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job new-jsoniq-2013-04-18T22-51-54.931Z is finished.  The
  final status was:

  

  No tests were run - build or configure step must have failed.

  Not commiting changes.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159739
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-18 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job new-jsoniq-2013-04-18T23-01-21.401Z is finished.  The
  final status was:

  

  No tests were run - build or configure step must have failed.

  Not commiting changes.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159739
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-18 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1, Needs Information  1, Resubmit  1. Got: 1 
Approve, 1 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159739
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-17 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job new-jsoniq-2013-04-17T18-23-02.191Z is finished.  The
  final status was:

  

  2 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159274
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-17 Thread Nicolae Brinza
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159477
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-17 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1, Needs Information  1, Resubmit  1. Got: 1 
Approve, 1 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159477
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-17 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1, Needs Information  1, Resubmit  1. Got: 1 
Approve, 1 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159477
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-17 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159477
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-16 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: 

text conflict in src/compiler/parser/jsoniq_parser.cpp
text conflict in src/compiler/parser/jsoniq_parser.hpp
text conflict in src/compiler/parser/jsoniq_scanner.cpp
text conflict in src/compiler/parser/xquery_parser.cpp
text conflict in src/compiler/parser/xquery_parser.hpp
text conflict in src/compiler/parser/xquery_scanner.cpp
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159267
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-16 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


Traceback (most recent call last):
  File /home/ceej/zo/testing/zorbatest/tester/proposal_comment.py, line 36, 
in module
sys.exit(main(sys.argv))
  File /home/ceej/zo/testing/zorbatest/tester/proposal_comment.py, line 34, 
in main
proposal.lp_save()
  File 
/home/ceej/python/lib/python2.7/site-packages/lazr/restfulclient/resource.py, 
line 744, in lp_save
URI(self.self_link), representation, headers)
  File 
/home/ceej/python/lib/python2.7/site-packages/lazr/restfulclient/_browser.py, 
line 456, in patch
'PATCH', extra_headers=extra_headers)
  File 
/home/ceej/python/lib/python2.7/site-packages/lazr/restfulclient/_browser.py, 
line 401, in _request
raise error
lazr.restfulclient.errors.PreconditionFailed: HTTP Error 412: Precondition 
Failed
Response headers:
---
-content-encoding: gzip
content-length: 0
content-type: text/plain
date: Wed, 17 Apr 2013 01:23:53 GMT
server: zope.server.http (HTTP)
status: 412
strict-transport-security: max-age=2592000
vary: Accept,Accept-Encoding
via: 1.1 api.launchpad.net
x-content-type-options: nosniff
x-content-type-warning: guessed from content
x-frame-options: SAMEORIGIN
x-lazr-notifications: []
x-powered-by: Zope (www.zope.org), Python (www.python.org)
x-xss-protection: 1; mode=block
---
Response body:
---

---

CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job new-jsoniq-2013-04-17T01-23-48.66Z is finished.  The
  final status was:

  

  Undetermined, probably an error - please email chill...@lambda.nu with the
  number of this job!


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159267
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-16 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job new-jsoniq-2013-04-17T01-24-44.705Z is finished.  The
  final status was:

  

  70 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/159274
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-09 Thread Matthias Brantner
Review: Approve

Looks good. I have added a test. I approve but I don't understand why the 
generated xquery parser and scanner files are updated in this merge proposal.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/157559
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-09 Thread Nicolae Brinza
I'm not sure either. It might be that the scanner .cpp file in the trunk had 
been generated with a different version of flex so cmake decided to rebuild it. 
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/157559
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-07 Thread Nicolae Brinza
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/157559
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-04-07 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1, Needs Information  1, Resubmit  1. Got: 1 
Approve, 1 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/157559
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-03-26 Thread Nicolae Brinza
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/155270
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-03-26 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job new-jsoniq-2013-03-26T07-34-49.835Z is finished.  The
  final status was:

  

  1 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/155270
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-03-26 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job new-jsoniq-2013-03-27T00-36-24.69Z is finished.  The
  final status was:

  

  1 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/155270
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-03-25 Thread Matthias Brantner
Review: Needs Fixing

I tried the following query:

jsoniq version 1.0; \u0041

IMHO, it should return a but it returns \u0041 instead. I think the parsing 
is done right but the parser also needs to replace the escapes, right?
-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/155270
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-03-25 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/155270
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-03-25 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job new-jsoniq-2013-03-26T02-28-47.758Z is finished.  The
  final status was:

  

  1 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/155270
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-03-22 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job new-jsoniq-2013-03-23T01-18-07.286Z is finished.  The
  final status was:

  

  3 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/154835
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-03-21 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job new-jsoniq-2013-03-22T00-59-31.055Z is finished.  The
  final status was:

  

  No tests were run - build or configure step must have failed.

  Not commiting changes.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/154835
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/new-jsoniq into lp:zorba

2013-03-21 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/new-jsoniq into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job new-jsoniq-2013-03-22T02-07-22.831Z is finished.  The
  final status was:

  

  No tests were run - build or configure step must have failed.

  Not commiting changes.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq/+merge/154835
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp