Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba

2011-12-24 Thread William Candillon
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86840
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba

2011-12-23 Thread William Candillon
Is there an example that works with streaming?
I wasn't able to make the following work:
import module namespace http = 
http://www.zorba-xquery.com/modules/http-client;;

declare namespace h = http://expath.org/ns/http-client;;

let $item := http:send-request(h:request 
href=https://stream.twitter.com/1/statuses/sample.json?delimited=length;
  method=GET
  username=wcandillon
  password=wnvbb86g
  override-media-type=text/plain
   /  
   ,   
   
https://stream.twitter.com/1/statuses/sample.json?delimited=length;,
   ()  
)[2]
for $tweet in tokenize($item,a)
return $tweet

Where:
import module namespace http = 
http://www.zorba-xquery.com/modules/http-client;;

declare namespace h = http://expath.org/ns/http-client;;

let $item := http:send-request(h:request 
href=https://stream.twitter.com/1/statuses/sample.json?delimited=length;
  method=GET
  username=wcandillon
  password=wnvbb86g
  override-media-type=text/plain
   /  
   ,   
   
https://stream.twitter.com/1/statuses/sample.json?delimited=length;,
   ()  
)[2]
return $item

streams fine.
What am I missing?
-- 
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86647
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba

2011-12-23 Thread Matthias Brantner
As discussed in this thread, only the new tokenize function of the string 
module streams.
Use the following instead

import module namespace s = http://www.zorba-xquery.com/modules/string;;

s:tokenize($item, a)
-- 
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86647
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba

2011-12-23 Thread William Candillon
Review: Approve

Works like a charm.
-- 
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86647
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba

2011-12-23 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: 

text conflict in ChangeLog
-- 
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86647
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba

2011-12-23 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86829
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba

2011-12-23 Thread William Candillon
Review: Approve

Works great.
-- 
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86829
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba

2011-12-23 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/tokenize into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:273 
(message):
  Validation queue job tokenize-2011-12-23T21-25-57.422Z is finished.  The
  final status was:

  

  1 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86829
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba

2011-12-23 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86835
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba

2011-12-23 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please 
seek review and approval of these new revisions.
-- 
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86835
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba

2011-12-23 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1. 
Got: 3 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86840
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba

2011-12-23 Thread William Candillon
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86835
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba

2011-12-21 Thread Paul J. Lucas
 Once you finished the implementation of the transcoding stream buffer, I don't
 even want to do this check anymore. This must not happen with the stream
 buffer.

I don't understand how it must not happen. It can always happen. However, I 
think you're saying that you assume the check will happen in the transcoder.  
While it will be doing checks, bad input can still happen.

In the mean time, using an assert() is still too Draconian.
-- 
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86626
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba

2011-12-21 Thread Matthias Brantner
I have replaced the assertion with a graceful error.
-- 
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86647
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/tokenize into lp:zorba

2011-12-21 Thread Paul J. Lucas
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/tokenize/+merge/86647
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp