Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/paging into lp:zorba

2012-06-28 Thread Matthias Brantner
Review: Needs Fixing - code conventions in collections_impl.cpp - getIterator(xs_integer aSkip) - should be getIterator(xs_integer aSkip) because xs_integer can be MAPM - could be one function with default parameter 0 - to_xs_long conversion in SimpleCollection can raise an error which should

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/paging into lp:zorba

2012-06-28 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~davidagraf/zorba/paging/+merge/112611 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/paging into lp:zorba

2012-06-28 Thread Matthias Brantner
Review: Approve The documentation of the two functions is a little weak. For example, it doesn't say what's happening to the skip parameter if it's negative or bigger than the size of the collection. Also, it would make sense to say that the function also makes sense for unordered collections

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/paging into lp:zorba

2012-06-28 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: text conflict in ChangeLog -- https://code.launchpad.net/~davidagraf/zorba/paging/+merge/112611 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :