Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/paging into lp:zorba

2012-06-28 Thread Matthias Brantner
Review: Needs Fixing

- code conventions in collections_impl.cpp
- getIterator(xs_integer aSkip)
  - should be getIterator(xs_integer aSkip) because xs_integer can be MAPM
  - could be one function with default parameter 0
- to_xs_long conversion in SimpleCollection can raise an error which should be 
caught somewhere in the iterator and a location needs to be added
- CollectionIter(SimpleCollection* collection, xs_integer aSkip); = 
CollectionIter(SimpleCollection* collection, xs_integer aSkip);
- store::Iterator_t getIterator(xs_integer aSkip); = store::Iterator_t 
getIterator(xs_integer aSkip);
- functions should be in the .xq modules and have documentation
- dml:collection(xs:QName(local:test2), -1) produces a segfault
- dml:collection(xs:QName(local:test2), x) produces a segfault if x is bigger 
than the size of the collection
- skip and count optimizations don't seem to play well together (maybe not 
needed)
-- 
https://code.launchpad.net/~davidagraf/zorba/paging/+merge/112611
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/paging into lp:zorba

2012-06-28 Thread Till Westmann
Review: Approve


-- 
https://code.launchpad.net/~davidagraf/zorba/paging/+merge/112611
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/paging into lp:zorba

2012-06-28 Thread Matthias Brantner
Review: Approve

The documentation of the two functions is a little weak. For example, it 
doesn't say what's happening to the skip parameter if it's negative or bigger 
than the size of the collection. Also, it would make sense to say that the 
function also makes sense for unordered collections because nodes are returned 
in a stable order.
-- 
https://code.launchpad.net/~davidagraf/zorba/paging/+merge/112611
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/paging into lp:zorba

2012-06-28 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: 

text conflict in ChangeLog
-- 
https://code.launchpad.net/~davidagraf/zorba/paging/+merge/112611
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp