Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Till Westmann
I've changed the catch(...) in translator.cpp and I've put the correct exception message back into the test. However, I don't see why the exception is reported twice, if the test fails. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/108894 Your team Zorba Coders is

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/110410 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 2 Approve, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/110410 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-14 Thread Chris Hillery
Review: Approve I think I mis-read the diff last time when I mentioned the double output of exceptions (I didn't see it as two separate catch() clauses). Latest changes look fine. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1009366/+merge/110410 Your team Zorba Coders is subscribed

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1009366 into lp:zorba

2012-06-09 Thread Chris Hillery
Please add the correct exception message back in test_userdefined_uri_resolvers, so that it is clear when the test passes. Also, as it is, if the test fails you will report the exception twice; that's probably not necessary. Other than that and Markos' comment, looks fine. --