Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1023862 into lp:zorba

2012-07-13 Thread Dennis Knochenwefel
 Why didn't you just assign the bug to me?  (Or why don't you just assign it to
 me now?)

did that. Thanks for helping.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1023862/+merge/114621
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1023862 into lp:zorba

2012-07-13 Thread Paul J. Lucas
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1023862/+merge/114881
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1023862 into lp:zorba

2012-07-13 Thread Dennis Knochenwefel
Review: Approve

there was a change in src/store/naive/item.cpp that made the build fail on 
windows. After removing that it built fine and all file tests known to pass 
passed.

perfect.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1023862/+merge/114881
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1023862 into lp:zorba

2012-07-12 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1. Got: 2 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1023862/+merge/114621
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1023862 into lp:zorba

2012-07-12 Thread Paul J. Lucas
You really should use fs::append() and not append / or name manually.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1023862/+merge/114621
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1023862 into lp:zorba

2012-07-12 Thread Paul J. Lucas
You should also factor out the common code for checking for . or ...
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1023862/+merge/114621
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1023862 into lp:zorba

2012-07-12 Thread Paul J. Lucas
Why didn't you just assign the bug to me?  (Or why don't you just assign it to 
me now?)
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug-1023862/+merge/114621
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp