Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-04-24 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-04-24 Thread Rodolfo Ochoa
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-04-17 Thread Paul J. Lucas
Line 73 in the diff is not a logically equivalent change. You should seek approval from whoever's code that is. I'll approve if that person approves. -- https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-04-16 Thread Rodolfo Ochoa
I corrected all size_types only one warning couldn't solve, I don't know how to solve this: 1c:\dev\bug1100471\src\zorbatypes\integer.h(916): warning C4146: unary minus operator applied to unsigned type, result still unsigned (..\..\src\zorbatypes\integer.cpp) 1

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-04-16 Thread Paul J. Lucas
Review: Needs Fixing You don't hack the parser.cpp or lexer.cpp files directly. Please revert ALL changes to those files and modify the .y or .l files ONLY. If the warnings still persist in those files due to generated code, it's simply too bad. In general, you don't need to fully qualify

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-28 Thread Rodolfo Ochoa
Done! I have made all the changes you observed. -- https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-28 Thread Paul J. Lucas
213,222,231,240,243,252: should be cast to Members::size_type. 296,297: Should be vectorchar::size_type (why are you obsessing over std::string::size_type?) 310,319,332: Should be cast to checked_vectorstore::Item_t::size_type not size_t. 358,367,393,403,404,417: Cast to wrong type. It seems

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-26 Thread Paul J. Lucas
Review: Needs Fixing In several cases where you added casts, you cast to the wrong type, e.g., the wrong size_type or something that should have been size_t. The only reason it got rid of the warnings in those cases is because the wrong type and the correct type just so happened to be the

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-24 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: text conflict in src/store/naive/simple_store.cpp -- https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-24 Thread Rodolfo Ochoa
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-24 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-24 Thread Chris Hillery
I'd actually prefer Paul to look at these, since he's the C++ guru and can hopefully say if there are any gotchas. -- https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-21 Thread Chris Hillery
Fixed the RQ problems, trying again. -- https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-21 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job bug1100471-2013-01-21T09-24-43.929Z is finished. The final

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-20 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job bug1100471-2013-01-20T21-18-47.689Z is finished. The final

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-19 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job bug1100471-2013-01-20T00-03-03.437Z is finished. The final