Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-04-24 Thread Paul J. Lucas
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-04-24 Thread Rodolfo Ochoa
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-04-17 Thread Paul J. Lucas
Line 73 in the diff is not a logically equivalent change. You should seek 
approval from whoever's code that is.  I'll approve if that person approves.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-04-16 Thread Rodolfo Ochoa
I corrected all size_types
only one warning couldn't solve, I don't know how to solve this:

1c:\dev\bug1100471\src\zorbatypes\integer.h(916): warning C4146: unary minus 
operator applied to unsigned type, result still unsigned 
(..\..\src\zorbatypes\integer.cpp)
1  c:\dev\bug1100471\src\zorbatypes\integer.h(915) : while compiling 
class template member function 'zorba::IntegerImplIntType 
zorba::IntegerImplIntType::operator -(void) const'
1  with
1  [
1  IntType=unsigned __int64
1  ]
1  ..\..\src\zorbatypes\integer.cpp(453) : see reference to class 
template instantiation 'zorba::IntegerImplIntType' being compiled
1  with
1  [
1  IntType=unsigned __int64
1  ]
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-04-16 Thread Paul J. Lucas
Review: Needs Fixing

You don't hack the parser.cpp or lexer.cpp files directly.  Please revert ALL 
changes to those files and modify the .y or .l files ONLY.  If the warnings 
still persist in those files due to generated code, it's simply too bad.

In general, you don't need to fully qualify casts, e.g., you can do 
static_castsize_type(x) rather than static_castzorba::base64::size_type(x).

I've fixed several formatting things (to put the code back to my style) and 
also a few other things. You should also seek approval from whoever else's code 
you touch.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/159239
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-28 Thread Rodolfo Ochoa
Done!
I have made all the changes you observed.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-28 Thread Paul J. Lucas
213,222,231,240,243,252: should be cast to Members::size_type.

296,297: Should be vectorchar::size_type (why are you obsessing over 
std::string::size_type?)

310,319,332: Should be cast to checked_vectorstore::Item_t::size_type not 
size_t.

358,367,393,403,404,417: Cast to wrong type.

It seems like you missed fixing a few.  I also seems to be like you're simply 
guessing at what the correct type should be.  Do you understand how to 
determine the correct type?
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-26 Thread Paul J. Lucas
Review: Needs Fixing

In several cases where you added casts, you cast to the wrong type, e.g., the 
wrong size_type or something that should have been size_t.  The only reason it 
got rid of the warnings in those cases is because the wrong type and the 
correct type just so happened to be the same underlying type on Windows; but 
that's not necessarily the case on non-Windows platforms.

For example, in mem_streambuf.cpp, you cast size to string::size_type -- why?  
Strings have nothing to do with that code.  If you looked at the man page for 
memcpy(3), the type of the 3rd argument is clearly size_t, so that's what you 
should have cast to.

I've made corrections in my own code at least.

In my code, I prefer !!expr rather than expr != 0 for conversion to bool (saves 
typing) -- I've changed this myself.

In places where you added #ifdef __GNUC__, it would have been nice if you fixed 
the indentation and included the /* __GNUC__ */ comment on the #endif -- I've 
fixed this myself.

As for other casts, I didn't thoroughly review them (you should do that, not 
me), but they looked suspicious to me:

209: It's not clear to me that the cast should be to int. It probably ought to 
be to whatever the type of theContent's size_type is (if it has one).

227,230,239: Here you're casting to unsigned int for theContent even though you 
just cast to int on line 209.  Again, this should probably be some size_type.

252: Is unsigned long really correct for bytes_in_buffer?  Is there a 
streamsize?

261: You fixed this line but ignored line 259 that obviously casts to a 
different type.

274: Is int really the right type?  It probably should be theXmlTrees's 
size_type (if it has one).

283,296: Should probably be the type of the iterator's type's size_type.

322: Should probably be vectorstore::Item*::size_type not int.  (To save 
typing, just add a typedef to the class for vectorstore::Item*.)

331,357: Should probably be theItems's type's size_type not unsigned int.

Line numbers above refer to the line numbers of the diff on the launchpad merge 
proposal.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-24 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: 

text conflict in src/store/naive/simple_store.cpp
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-24 Thread Rodolfo Ochoa
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-24 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1. Got: 2 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-24 Thread Chris Hillery
I'd actually prefer Paul to look at these, since he's the C++ guru and can 
hopefully say if there are any gotchas.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-21 Thread Chris Hillery
Fixed the RQ problems, trying again.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-21 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job bug1100471-2013-01-21T09-24-43.929Z is finished.  The
  final status was:

  

  1 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-20 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job bug1100471-2013-01-20T21-18-47.689Z is finished.  The
  final status was:

  

  21 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/144035
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1100471 into lp:zorba

2013-01-19 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/bug1100471 into lp:zorba failed. 
Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 
(message):
  Validation queue job bug1100471-2013-01-20T00-03-03.437Z is finished.  The
  final status was:

  

  No tests were run - build or configure step must have failed.

  Not commiting changes.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1100471/+merge/143997
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp