Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug905035 into lp:zorba

2012-01-20 Thread Rodolfo Ochoa
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug905035/+merge/89099
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug905035 into lp:zorba

2012-01-18 Thread Markos Zaharioudakis
Matthias, the getNamespaceBindings method is rather inefficient as it will copy 
the actual strings twice. And it should also pre-allocated the space for the 
returned vector. I don't think this is going to be a major bottleneck, so I 
have approved the proposal. But in the spirit of best practices, it is better 
if it is fixed.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug905035/+merge/88922
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug905035 into lp:zorba

2012-01-18 Thread Markos Zaharioudakis
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug905035/+merge/88922
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug905035 into lp:zorba

2012-01-18 Thread Markos Zaharioudakis
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug905035/+merge/89099
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug905035 into lp:zorba

2012-01-17 Thread Matthias Brantner
I have adapted the fix as suggested. However, I'm not sure how to address 
Rodolfo's issues regarding other language bindings. This seems to be a bigger 
problem which is present in many places in our api.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug905035/+merge/88922
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug905035 into lp:zorba

2012-01-17 Thread Rodolfo Ochoa
Review: Approve

I think I can use it like it is now...
BTW: NSBindings class is no on zorba website's documentation

-- 
https://code.launchpad.net/~zorba-coders/zorba/bug905035/+merge/88922
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug905035 into lp:zorba

2012-01-13 Thread Hybridum
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/bug905035/+merge/88271
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug905035 into lp:zorba

2012-01-12 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1. 
Got: 1 Approve, 2 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug905035/+merge/88271
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug905035 into lp:zorba

2012-01-11 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1. 
Got: 2 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug905035/+merge/88271
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug905035 into lp:zorba

2012-01-11 Thread Rodolfo Ochoa
How hard is to get a zorba iterator instead?
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug905035/+merge/88271
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug905035 into lp:zorba

2012-01-11 Thread Chris Hillery
IMHO a Zorba iterator wouldn't be the appropriate way to return this 
information, since it would require wrapping each prefix into an Item (which 
the end-user would probably just call getStringValue() on anyway).
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug905035/+merge/88271
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug905035 into lp:zorba

2012-01-11 Thread Rodolfo Ochoa
Review: Approve

It's fine, just FYI, this wouldn't work on Ruby, any usage of vectors from STL 
are excluded from Ruby.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug905035/+merge/88271
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp