Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug907872 into lp:zorba

2012-01-03 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug907872/+merge/86738 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug907872 into lp:zorba

2012-01-03 Thread Markos Zaharioudakis
The ExtFuncArgItemSequence cannot live longer than the ExtFunctionCallIterator who created it, because it is just a wrapper over a child of the ExtFunctionCallIterator, and if the ExtFunctionCallIterator is destroyed, its children are destroyed as well. The real problem is that the

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug907872 into lp:zorba

2011-12-22 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug907872/+merge/86738 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug907872 into lp:zorba

2011-12-22 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1. Got: 1 Approve, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug907872/+merge/86738 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug907872 into lp:zorba

2011-12-22 Thread Markos Zaharioudakis
Matthias, I cannot see how the example you added illustrates the case where an ExtFuncArgItemSequence must live longer than the ExtFunctionCallIterator who created it. In fact, I tried the example without your modification in fncall_iterator.cpp and it worked fine. What am I missing? --