Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-18 Thread Sorin Marian Nasoi
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-18 Thread Sorin Marian Nasoi
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-18 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba 
failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 
(message):
  Validation queue job fix_bug_962255-2012-05-18T14-34-05.391Z is finished.
  The final status was:

  

  1 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-17 Thread Chris Hillery
Review: Approve

Ok, I have added the changes discussed. xqdoc now depends on modules_svg 
(Sorin, you had it the other way around, but I think this is what you meant). 
modules_svg will be a dummy target if the Graphviz modules is not declared. If 
it is declared, it will generate the .svg file.

I'm voting Approve on this change. Sorin, you should inspect my changes and, if 
they seem OK, go ahead and mark the proposal Approved to run it through the 
queue.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-17 Thread Sorin Marian Nasoi
 Ok, I have added the changes discussed. xqdoc now depends on modules_svg
 (Sorin, you had it the other way around, but I think this is what you meant).
 modules_svg will be a dummy target if the Graphviz modules is not declared. If
 it is declared, it will generate the .svg file.
Nope, the way it was correct.

make xqdoc deletes all previous output from build/doc/xqdoc and then 
regenerates the documentation. In the process of generating the new XQDoc 
documentation it will copy the default module dependency graph from 
doc/zorba/xqdoc/images/modules.svg to build/doc/xqdoc/xhtml/images/modules.svg

make modules_svg generates the new dependency graph in 
build/doc/xqdoc/xhtml/images/modules.svg

If it's the other way around (like you proposed) the following will happen:
make modules_svg generates the new dependency graph in 
build/doc/xqdoc/xhtml/images/modules.svg
make xqdoc deletes all previous output from build/doc/xqdoc and then 
regenerates the documentation. In the process of generating the new XQDoc 
documentation it will copy the default module dependency graph from 
doc/zorba/xqdoc/images/modules.svg to build/doc/xqdoc/xhtml/images/modules.svg

We can implement the way you suggest and have make modules_svg generate the 
output in doc/zorba/xqdoc/images/modules.svg.
The drawback of this approach is that mostly every time one runs make xqdoc 
and has Graphviz, they will see a file that was changed.


 I'm voting Approve on this change. Sorin, you should inspect my changes and,
 if they seem OK, go ahead and mark the proposal Approved to run it through the
 queue.
I will take a look on the changes: thanks for the help.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-17 Thread Sorin Marian Nasoi
Review: Needs Fixing


-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-17 Thread Chris Hillery
I'm a bit confused then... I thought the whole point of this exercise was to 
ensure that the graph was regenerated every time. But with the dependencies the 
way you say, the modules_svg target will only ever be executed by hand. Am I 
missing something?
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-16 Thread Sorin Marian Nasoi
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-16 Thread Chris Hillery
Is there any difference between the old zorba_module_dependencies.xqi and the 
new zorba_module_dependencies.xqy ? Why was the filename changed?

Besides that, though, as mentioned on the other merge proposal, I don't think 
you can move the modules_svg target out of the core like this.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-16 Thread Sorin Marian Nasoi
 Is there any difference between the old zorba_module_dependencies.xqi and the
 new zorba_module_dependencies.xqy ? Why was the filename changed?
 
 Besides that, though, as mentioned on the other merge proposal, I don't think
 you can move the modules_svg target out of the core like this.
What is the best solution to check if an external module (Graphviz in this 
case) is build from within Zorba?

Thanks for the help.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-16 Thread Sorin Marian Nasoi
 Is there any difference between the old zorba_module_dependencies.xqi and the
 new zorba_module_dependencies.xqy ? Why was the filename changed?
The module itself was mostly re-written, but the reason for the extension 
change is XQDT: xqy is not a default extension for XQuery, while xqi is.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-16 Thread Chris Hillery
Ok, so as discussed, the reason you moved the modules_svg target and associated 
dependencies was because you could not otherwise know whether Graphviz was 
available.

If so, then please do the following:

1. Change this fix_bug_962255 branch to always create the modules_svg target 
(as it appears that it used to do, but was commented out) and ensure that this 
works correctly when Graphviz *is* present.

2. Delete the fix_bug_962255_image_module proposal and branch (I believe they 
will no longer be necessary, correct?).

Then, I will add some code to allow detection of whether a non-core module 
exists, and put the appropriate wrapper around the modules_svg target.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255 into lp:zorba

2012-05-16 Thread Sorin Marian Nasoi
  Is there any difference between the old zorba_module_dependencies.xqi and
 the
  new zorba_module_dependencies.xqy ? Why was the filename changed?
 The module itself was mostly re-written, but the reason for the extension
 change is XQDT: xqy is not a default extension for XQuery, while xqi is.
Sorry it's the other way around: in XQDT .xqi is not a default extension for 
XQuery files while .xqy is.
-- 
https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255/+merge/105989
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp