Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-10 Thread Markos Zaharioudakis
Federico I made some changes to the branch, the most important of which is that I removed from SimpleStore the methods related to copying of identifiers. I guess you will have to put this code back in the branch where it is actually used. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-10 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: text conflict in test/rbkt/Queries/CMakeLists.txt -- https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-10 Thread Federico Cavalieri
Federico I made some changes to the branch, the most important of which is that I removed from SimpleStore the methods related to copying of identifiers. I guess you will have to put this code back in the branch where it is actually used. OK, Thanks. I am going to fix the arisen merge

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Federico Cavalieri
pPlease see the a href=../../html/data_lifecycle.htmldata lifecycle documentation/a about details on management and manipulation of collections./p = pPlease see the a href=../../html/data_lifecycle.htmldata lifecycle documentation/a about details on storing nodes in collections or as

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Federico Cavalieri
More comments on the documentation inside node-reference.xq: 1. I think the definition of immutable should say: i.e. a node identifier does not change during the node lifetime, and cannot be reused for another node after the original node gets deleted. instead of just i.e. a node

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Federico Cavalieri
The function returns the empty sequence if the node that is referenced was deleted. = The function returns the empty sequence if the node that is referenced does not exist (e.g. because it was deleted or the temporary node is not available anymore) Done. I wouldn't add the

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Markos Zaharioudakis
4. Should we say something about text nodes, eg, that their identifier is not really immutable and it can be used to dereference the node only during the same snapshot in which the identifier was retrieved? This refers to the other module, the one with the structural uris.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Markos Zaharioudakis
What is the CopyMode's theCopyReference member for? Isn't it always false? Yes in the current module it is. Should I move it in the branch which uses it/by itself? YES! I made the same suggestion in one of my other comments. Identifiers are useful by themselves, i.e., independently from

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Federico Cavalieri
Identifiers are useful by themselves, i.e., independently from the PUL- manipulation module. So, this branch should be about identifiers only. Anything that is relevant to PUL-manipulation should be moved to the associated branch. What about the hasIdentifier and similar functions offered in

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Federico Cavalieri
YES! I made the same suggestion in one of my other comments. OK. I was in the middle of the process of moving them -- https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Federico Cavalieri
Federico, on Wednesday, we agreed that you send us an example that shows when you have to copy over the identifier of a node that is being copied. Have you done it? (it's possible that I missed it in the deluge of emails). Done and sent --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Matthias Brantner
Review: Approve I'm fine with it now. -- https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-06 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 0, Disapprove 1. Got: 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-06 Thread Federico Cavalieri
I think identifies was identities. Fixing again -- https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-06 Thread Matthias Brantner
Review: Needs Fixing pPlease see the a href=../../html/data_lifecycle.htmldata lifecycle documentation/a about details on management and manipulation of collections./p = pPlease see the a href=../../html/data_lifecycle.htmldata lifecycle

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-01 Thread Markos Zaharioudakis
In simple_store.cpp:1351, we should be creating a URI item, not a string item, right? -- https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/77693 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-01 Thread Federico Cavalieri
In simple_store.cpp:1351, we should be creating a URI item, not a string item, right? Yes, we should always create anyURIs. Missed that when change when we switched from strings to anyURIs. Fixing right now. -- https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/77693 Your team