Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-10 Thread Markos Zaharioudakis
Federico I made some changes to the branch, the most important of which is that 
I removed from SimpleStore the methods related to copying of identifiers. I 
guess you will have to put this code back in the branch where it is actually 
used.
-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-10 Thread Zorba Build Bot
Attempt to merge into lp:zorba failed due to conflicts: 

text conflict in test/rbkt/Queries/CMakeLists.txt
-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-10 Thread Federico Cavalieri
 Federico I made some changes to the branch, the most important of which is
 that I removed from SimpleStore the methods related to copying of identifiers.
 I guess you will have to put this code back in the branch where it is actually
 used.

OK, Thanks.

I am going to fix the arisen merge conflicts.

-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Federico Cavalieri
 pPlease see the a href=../../html/data_lifecycle.htmldata lifecycle
  documentation/a about details on management and manipulation of
 collections./p
 =
 pPlease see the a href=../../html/data_lifecycle.htmldata lifecycle
  documentation/a about details on storing nodes in collections or as
 documents./p

Done.
 
 Computes an immutable and opaque node reference
 =
 Returns an immutable and opaque node reference...
 
Done.

 The function returns the empty sequence if the node
 that is referenced was deleted.
 =
 The function returns the empty sequence if the node
 that is referenced does not exist (e.g. because it was deleted or the
 temporary node is not available anymore)
 
Done.

 zerr::ZAPI0028
 =
 zerr:ZAPI0028
 

Done.

 Can any of the functions return ZAPI0029? If so, it's not documented. Same for
 ZAPI0030.
 

They cannot be raised by the functions in this module. However they can be 
raised when some of the simple_store methods are called directly, like i do in 
my pul module. 
An example could be a PUL which requires to insert a node with an identity 
which is already assigned to another node. (Either the same PUL/operation is 
applied twice or the user is using crafting ids). In those function these 
errors are either catched and wrapped into other errors or thrown.

 
 fix indentation in NodeByReferenceIterator (two spaces)

Done
 Also, add a space before and after the assignment
Done, also in the other module
 
 Fix comment in FnGenerateIdIterator = remove e.g. z0.1.1.c.50
Done.
 
 Why is hasReference still needed?
I use this in my pul module to verify whether a node has a reference or not.

 
 What is the following change in node_items.cpp for?
 513 -theTypesMap = new
 NodeTypeMap(source-theTypesMap-object_count(), false);
 514 +theTypesMap = new NodeTypeMap(source-theTypesMap-size(),
 false);

I think Markos changed it when he replaced one of my tree-based maps with a 
more efficient hash-based map.

 What is the CopyMode's theCopyReference member for? Isn't it always false?
Yes in the current module it is. Should I move it in the branch which uses 
it/by itself?
-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Federico Cavalieri
 More comments on the documentation inside node-reference.xq:
 
 1. I think the definition of immutable should say:
 
 i.e. a node identifier does not change during the node lifetime, and cannot be
 reused for another node after the original node gets deleted.
 
 instead of just
 
 i.e. a node identifier does not change during the node lifetime
 

Done.


 2. I don't like this sentence:
 
 Identifiers are also unique, in that, two nodes with different identities
 will never have identical identifiers..
 
 Identifiers are actually an implementation of the node identity concept
 defined by the w3c specs. So the above sentence is a tautology. I would say
 the following:
 
 Identifiers are also unique, in that, two different nodes will never have the
 same identifier..

Done.
 
 3. When we say any node, I don't think it is necessary to add either
 temporary or stored in a collection. What is a temporary node after all?
 There is no definition for temporary or persistent nodes anywhere.
 

Done.

 4. Should we say something about text nodes, eg, that their identifier is not
 really immutable and it can be used to dereference the node only during the
 same snapshot in which the identifier was retrieved?

This refers to the other module, the one with the structural uris. 
Identifiers/references work the same for every node. Structural uris cannot be 
dereferenced (our choice), so it is not a problem.
We never say however that the structural relationship of a non-text node 
remains the same in the node lifetime. Maybe we should. What do you think?
-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Federico Cavalieri
 
  The function returns the empty sequence if the node
  that is referenced was deleted.
  =
  The function returns the empty sequence if the node
  that is referenced does not exist (e.g. because it was deleted or the
  temporary node is not available anymore)
 
 

Done.

 I wouldn't add the (e.g. because ) part. After all, a temporary node
 becomes not available by being deleted. So, the phrase does not really add any
 additional info.
 
  zerr::ZAPI0028
  =
  zerr:ZAPI0028
 
  Can any of the functions return ZAPI0029? If so, it's not documented. Same
 for
  ZAPI0030.
 
 
 I am not sure, but these 2 errors are being used just for internal sanity
 checks. If so, they should be removed from the diagnostics list (use
 ZORBA_ASSERT() instead).

They cannot be raised by the functions in this module. However they can be 
raised when some of the simple_store methods are called directly, like i do in 
my pul module. 
An example could be a PUL which requires to insert a node with an identity 
which is already assigned to another node. (Either the same PUL/operation is 
applied twice or the user is using crafting ids). In those function these 
errors are either catched and wrapped into other errors or thrown.


-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Markos Zaharioudakis

  4. Should we say something about text nodes, eg, that their identifier is
 not
  really immutable and it can be used to dereference the node only during the
  same snapshot in which the identifier was retrieved?
 
 This refers to the other module, the one with the structural uris.
 Identifiers/references work the same for every node. Structural uris cannot be
 dereferenced (our choice), so it is not a problem.
 We never say however that the structural relationship of a non-text node
 remains the same in the node lifetime. Maybe we should. What do you think?

Sorry, I got confused again between identifiers and ordpaths.
-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Markos Zaharioudakis

  What is the CopyMode's theCopyReference member for? Isn't it always false?
 Yes in the current module it is. Should I move it in the branch which uses
 it/by itself?

YES! I made the same suggestion in one of my other comments. 

Identifiers are useful by themselves, i.e., independently from the 
PUL-manipulation module. So, this branch should be about identifiers only. 
Anything that is relevant to PUL-manipulation should be moved to the associated 
branch.

-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Federico Cavalieri
 Identifiers are useful by themselves, i.e., independently from the PUL-
 manipulation module. So, this branch should be about identifiers only.
 Anything that is relevant to PUL-manipulation should be moved to the
 associated branch.

What about the hasIdentifier and similar functions offered in the store?
They seems to be on the edge between being general utility functions and
something specific to the PUL module,
-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp



Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Federico Cavalieri
 
 YES! I made the same suggestion in one of my other comments.
 

OK. I was in the middle of the process of moving them
-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Federico Cavalieri
 Federico, on Wednesday, we agreed that you send us an example that shows when
 you have to copy over the identifier of a node that is being copied. Have you
 done it? (it's possible that I missed it in the deluge of emails).

Done and sent
-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-07 Thread Matthias Brantner
Review: Approve

I'm fine with it now.
-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-06 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  0, Disapprove  1. 
Got: 1 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-06 Thread Federico Cavalieri
I think identifies was identities.
Fixing again
-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-06 Thread Matthias Brantner
Review: Needs Fixing

pPlease see the a href=../../html/data_lifecycle.htmldata lifecycle   
   
 documentation/a about details on management and manipulation of 
collections./p
=
pPlease see the a href=../../html/data_lifecycle.htmldata lifecycle   
   
 documentation/a about details on storing nodes in collections or as 
documents./p


Computes an immutable and opaque node reference 
=
Returns an immutable and opaque node reference...

The function returns the empty sequence if the node
that is referenced was deleted.
=
The function returns the empty sequence if the node
that is referenced does not exist (e.g. because it was deleted or the temporary 
node is not available anymore)

zerr::ZAPI0028
=
zerr:ZAPI0028

Can any of the functions return ZAPI0029? If so, it's not documented. Same for 
ZAPI0030.


fix indentation in NodeByReferenceIterator (two spaces)
Also, add a space before and after the assignment

Fix comment in FnGenerateIdIterator = remove e.g. z0.1.1.c.50

Why is hasReference still needed?

What is the following change in node_items.cpp for?
513 -theTypesMap = new NodeTypeMap(source-theTypesMap-object_count(), 
false);
514 +theTypesMap = new NodeTypeMap(source-theTypesMap-size(), false);

What is the CopyMode's theCopyReference member for? Isn't it always false?
-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/78383
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-01 Thread Markos Zaharioudakis
In simple_store.cpp:1351, we should be creating a URI item, not a string item, 
right?
-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/77693
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/identifiers into lp:zorba

2011-10-01 Thread Federico Cavalieri
 In simple_store.cpp:1351, we should be creating a URI item, not a string item,
 right?

Yes, we should always create anyURIs.
Missed that when change when we switched from strings to anyURIs.
Fixing right now.
-- 
https://code.launchpad.net/~zorba-coders/zorba/identifiers/+merge/77693
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp