Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-19 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460 Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-18 Thread Chris Hillery
Review: Approve I initially saw some bad memory hits when I did a build of this branch as well, but after merging the latest trunk and doing a clean build, it all looks good. I do not see the memory leaks Sorin noted; I ran the url- tests with valgrind, and the only memory leaks reported were

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-18 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job xqxq-url-resolver-2012-10-18T06-21-40.181Z

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-18 Thread Chris Hillery
Whoops, right - this merge proposal won't pass until https://code.launchpad.net/~zorba-coders/zorba/zorba-xqxq-url-resolver/+merge/123602 is merged. Ignore these test failures for now. -- https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/123604 Your team Zorba Coders is

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-18 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/123604 Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-18 Thread Matthias Brantner
Review: Needs Fixing I don't feel comfortable with the QName solution. It would be great if HOFs could be used for this. As far as I understood earlier discussions, this should have been developed together with Nicolae. Using HOFs would also solve the static context problem. Maybe the HOF

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-18 Thread Chris Hillery
Review: Approve Now using HOF! -- https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460 Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-18 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1, Needs Fixing 1, Pending 1. Got: 1 Approve, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460 Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module. --

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-18 Thread Matthias Brantner
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460 Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe :

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-05 Thread Sorin Marian Nasoi
Review: Needs Fixing There is a memory leak in the implementation. To check simply run ctest -R url- and look into the build/Testing/Temporary/LastTest.log. Here is what you will see: test xqxq/url-schema-resolver [...] === end of result === testdriver: success (non-canonical result # 1