Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-19 Thread Sorin Marian Nasoi
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460
Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-18 Thread Chris Hillery
Review: Approve

I initially saw some bad memory hits when I did a build of this branch as well, 
but after merging the latest trunk and doing a clean build, it all looks good. 
I do not see the memory leaks Sorin noted; I ran the url- tests with valgrind, 
and the only memory leaks reported were the known ones from inside the 
http-client module.

Sorin, please re-review now; if you see any problems, try a completely clean 
re-build. Thanks.
-- 
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/123604
Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-18 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/xqxq-url-resolver into 
lp:zorba/xqxq-module failed. Below is the output from the failed tests.


CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 
(message):
  Validation queue job xqxq-url-resolver-2012-10-18T06-21-40.181Z is
  finished.  The final status was:

  

  6 tests did not succeed - changes not commited.


Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

-- 
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/123604
Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-18 Thread Chris Hillery
Whoops, right - this merge proposal won't pass until 
https://code.launchpad.net/~zorba-coders/zorba/zorba-xqxq-url-resolver/+merge/123602
 is merged. Ignore these test failures for now.
-- 
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/123604
Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-18 Thread Sorin Marian Nasoi
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/123604
Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-18 Thread Matthias Brantner
Review: Needs Fixing

I don't feel comfortable with the QName solution. It would be great if HOFs 
could be used for this. As far as I understood earlier discussions, this should 
have been developed together with Nicolae. Using HOFs would also solve the 
static context problem. Maybe the HOF feature already allows this relatively 
simple use case.

Can a sequence of mappers be registered?

The documentation should say that mapper:uri-mapper should return xs:string*.

s/lilfetime/lifetime
s/recive/receive
s/namesapce/namespace
s/th /the /
-- 
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/123604
Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-18 Thread Chris Hillery
Review: Approve

Now using HOF!
-- 
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460
Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-18 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve  1, Disapprove  1, 
Needs Fixing  1, Pending  1. Got: 1 Approve, 2 Pending.
-- 
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460
Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-18 Thread Matthias Brantner
Review: Approve


-- 
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/130460
Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp


Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xqxq-url-resolver into lp:zorba/xqxq-module

2012-10-05 Thread Sorin Marian Nasoi
Review: Needs Fixing

There is a memory leak in the implementation.

To check simply run 
ctest -R url-
and look into the build/Testing/Temporary/LastTest.log.

Here is what you will see:

test xqxq/url-schema-resolver
[...]
=== end of result ===
testdriver: success (non-canonical result # 1 matches)
testdriver: test runtime was 37041us
testdriver: success
ID: 78 Referenced URI: http://www.zorba-xquery.com/modules/xqxq/url-resolver
ID: 113 Referenced URI: http://www.zorba-xquery.com/modules/xqxq
terminate called after throwing an instance of 'zorba::ZorbaException'
  what():  Zorba did not close properly, objects may still in memory.
2 referenced URI(s) remain in the string pool.
For help avoiding this message please refer to 
http://www.zorba-xquery.com/html/documentation in section General Architecture 
- Memory Leaks.

-- 
https://code.launchpad.net/~zorba-coders/zorba/xqxq-url-resolver/+merge/123604
Your team Zorba Coders is subscribed to branch lp:zorba/xqxq-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp