Re: [O] [PATCH 5/9] rename `org-duration-string-to-minutes' to `org-clocksum-string-to-minutes' everywhere

Aaron Ecay writes: > You can use ‘define-obsolete-function-alias’. Ok.

[O] [PATCH] remove some copy-paste and add date support to org-notmuch-store-link

Cheers, Jan Jan Malakhovski (2): factor out date-timestamp* calculations to org-store-link-props org-notmuch: add date support to org-notmuch-store-link contrib/lisp/org-mew.el | 11 +-- contrib/lisp/org-notmuch.el | 7 --- contrib/lisp/org-vm.el | 11

[O] [PATCH v3 part1 0/3] Fixes

Hello. This is a fixes-only piece of "[PATCH v2 0/9] mail, clock and calc changes" updated with Aaron Ecay's suggestions. Other pieces will follow shortly. I'm pretty sure FSF processed my copyright assignment. Cheers, Jan Jan Malakhovski (3): org-clock: fix a typo ob-calc: d

[O] [PATCH v3 part2 0/2] date-timestamp* calculations

This is a date-timestamp* piece of "[PATCH v2 0/9] mail, clock and calc changes" updated with Aaron Ecay's suggestions. Jan Malakhovski (2): factor out date-timestamp* calculations to org-store-link-props org-notmuch: add date support to org-notmuch-store-link contrib/lisp/

Re: [O] [PATCH 2/2] org-notmuch: add date support to org-notmuch-store-link

Hello, Jan Malakhovski <o...@oxij.org> writes: > * contrib/lisp/org-notmuch.el (org-notmuch-store-link): Add date support. > * doc/org.texi: Fix `org-capture-templates' documentation. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH 2/3] ob-calc: don't leave garbage on the stack

Hello, Jan Malakhovski <o...@oxij.org> writes: > * lisp/ob-calc.el (org-babel-calc-eval-string): Clean up the stack after > expression > evaluation. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH 3/3] org-contacts: fix org-contacts-matcher for BIRTHDAYs

Hello, Jan Malakhovski <o...@oxij.org> writes: > * contrib/lisp/org-contacts.el (org-contacts-matcher): Fix expression > to work for BIRTHDAY-only contacts. Applied. Thank you. Regards, -- Nicolas Goaziou

[O] [PATCH] make org-clock-time% respect org-effort-durations and related

consciously use that code path and I'm not sure what it supposed to do). Cheers, Jan Jan Malakhovski (4): org-clock: make org-clock-time% respect org-effort-durations org: move org-duration-string-to-minutes to a better place rename org-duration-string-to-minutes to org-clocksum-string

Re: [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint

Jan Malakhovski <o...@oxij.org> writes: > Okay, so I bisected and found that the offender is > 9f5e698679aecbed872a2030e4157e5e2b1d87e0. Since then these lines have > changed, so the following [...] > I'm willing to listen, but I seriously doubt there's such a compelling &g

Re: [O] [PATCH 3/9] org-clock: fix `org-clock-time%'

Aaron Ecay writes: > This could be converted to dolist while you’re here (I realize you > didn’t touch this line). Ok. >> - (if (string-match "\\([0-9]+\\):\\([0-9]+\\)" s) >> - (throw 'exit >> - (/ (* 100.0 (+ (string-to-number (match-string

Re: [O] [PATCH 9/9] ob-calc: don't leave garbage on the stack

2015ko azaroak 4an, Jan Malakhovski-ek idatzi zuen: > > Aaron Ecay <aarone...@gmail.com> writes: > >> Are you missing a close paren at the end of the above line? > > It evaluates and works ok, so I think it's ok. Ok. Then: 1. The indentation is wrong, because

Re: [O] [PATCH 9/9] ob-calc: don't leave garbage on the stack

Aaron Ecay writes: > Ok. Then: > 1. The indentation is wrong, because (calc-pop 1) is the second argument >to calc-eval. > 2. The prog1 form is not needed, because it only wraps a single form >(the calc-eval call). > > This looks wrong to me, so please double-check.

Re: [O] [PATCH 1/2] factor out date-timestamp* calculations to org-store-link-props

Hello, Jan Malakhovski <o...@oxij.org> writes: > * lisp/org.el (org-store-link-props): Rewrite function to get date-timestamp* > calculations. > * lisp/org-gnus.el: > * lisp/org-mhe.el: > * lisp/org-rmail.el: > * contrib/lisp/org-mew.el: > * contrib/lisp/org-vm.el:

Re: [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint

Jan Malakhovski <o...@oxij.org> writes: > Nicolas Goaziou <m...@nicolasgoaziou.fr> writes: > >>> * Pressing on an entry in org-agenda-list moves the cursor to the >>> corresponding node. >>> >>> Previously it moved the cursor to the

Re: [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint

Hello, Jan Malakhovski <o...@oxij.org> writes: > * C-c C-x C-i clocks in into a wrong node. > Instead of clocking-in into the node under cursor it clock-ins into the > next one. Fixed. Thank you. > * Pressing on an entry in org-agenda-list moves the cursor to the >

Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props

Aaron Ecay writes: > Checking the source, date-to-time can raise an error (invalid date). > format-time-string is a C function, so it’s less easy for me to > understand. But it looks like if it raises any errors, these are bugs > that we want to know about and not suppress.

[O] [PATCH 1/9] org-clock: fix a typo

TINYCHANGE --- lisp/org-clock.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-clock.el b/lisp/org-clock.el index 09f8391..ad423f1 100644 --- a/lisp/org-clock.el +++ b/lisp/org-clock.el @@ -2774,7 +2774,7 @@ following structure: (LEVEL HEADLINE TIMESTAMP TIME)

Re: [O] [PATCH 9/9] ob-calc: don't leave garbage on the stack

Aaron Ecay writes: > Are you missing a close paren at the end of the above line? It evaluates and works ok, so I think it's ok. > Also, shouldn’t calc-eval take a string as an argument, not a lisp > form? (I’m asking based on the docstring, I don’t know the calc API at >

Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props

Aaron Ecay writes: > Can you introduce a let binding so that (date-to-time x) is only called > once? Ok. > Also, what is ignore-errors protecting? The call to date-to-time, or > format-time-string? I think the scope of ignore-errors should be as > narrow as it can be. I

Re: [O] [PATCH 1/3] org-clock: fix a typo

Hello, Jan Malakhovski <o...@oxij.org> writes: > lisp/org-clock.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/org-clock.el b/lisp/org-clock.el > index eb7d9c3..823a386 100644 > --- a/lisp/org-clock.el > +++ b/lisp/org-clock.el > @

[O] [PATCH 1/3] org-clock: fix a typo

TINYCHANGE --- lisp/org-clock.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-clock.el b/lisp/org-clock.el index eb7d9c3..823a386 100644 --- a/lisp/org-clock.el +++ b/lisp/org-clock.el @@ -2762,7 +2762,7 @@ following structure: \(LEVEL HEADLINE TIMESTAMP TIME)

[O] [PATCH 2/3] ob-calc: don't leave garbage on the stack

* lisp/ob-calc.el (org-babel-calc-eval-string): Clean up the stack after expression evaluation. --- lisp/ob-calc.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/ob-calc.el b/lisp/ob-calc.el index a8c50da..99d0a09 100644 --- a/lisp/ob-calc.el +++ b/lisp/ob-calc.el

[O] [PATCH v2 0/9] mail, clock and calc changes

. The first two are TINYCHANGE. Cheers, Jan Jan Malakhovski (9): org-clock: fix a typo org-colview: add a FIXME org-clock: fix `org-clock-time%' org: move `org-duration-string-to-minutes' to a better place rename `org-duration-string-to-minutes' to `org-clocksum-string-to-minutes

[O] [PATCH v3 part3 0/4] fixing org-clock-time%

th ob-calc piece of "[PATCH v2 0/9] mail, clock and calc changes", I'll send it when its better. Cheers, Jan Jan Malakhovski (4): org: move `org-duration-string-to-minutes' to a better place rename `org-duration-string-to-minutes' to `org-clocksum-string-to-minutes' e

[O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint

ist moves the cursor to the corresponding node. Previously it moved the cursor to the corresponding CLOCK: line and I used that a lot. Cheers, Jan * Test ** Test test ** Test test * Test * Test

Re: [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint

nda-list items. For me this is critical, because I clock everything, have megabytes of CLOCK: entries and edit them a lot. Cheers, Jan

Re: [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint

s (intervals) ** Press `` * Expected: cursor jump to the corresponding CLOCK:. * Got: cursor jump to "Test" line. Cheers, Jan * Test :LOGBOOK: CLOCK: [2015-10-25 Sun 17:00]--[2015-10-25 Sun 18:00] => 1:00 CLOCK: [2015-10-25 Sun 16:00]--[2015-10-25 Sun 17:00] => 1:00 :END:

Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props

Hi Jan, 2015ko azaroak 4an, Jan Malakhovski-ek idatzi zuen: [...] >> Also, what is ignore-errors protecting? The call to date-to-time, or >> format-time-string? I think the scope of ignore-errors should be as >> narrow as it can be. > > I have no idea. I moved t

Re: [O] [PATCH 9/9] ob-calc: don't leave garbage on the stack

Hi Jan, 2015ko azaroak 3an, Jan Malakhovski-ek idatzi zuen: > > * lisp/ob-calc.el (org-babel-calc-eval-string): Clean up the stack after > expression > evaluation. > --- > lisp/ob-calc.el | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: [O] [PATCH v2 0/9] mail, clock and calc changes

ce it is only code movement > with no actual changes). I'm fine either way, including patch 4. If somebody merges those, I'll just resend the rest when I fix the pieces you pointed to. Cheers, Jan

Re: [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint

Jan Malakhovski <o...@oxij.org> writes: > Nicolas Goaziou <m...@nicolasgoaziou.fr> writes: > >> Could you provide an ECM with appropriate CLOCK lines? > > Attached. Okay, so I bisected and found that the offender is 9f5e698679aecbed872a2030e4157e5e2b1d87e0. Since

[O] [PATCH 4/4] org-colview: add a FIXME

--- lisp/org-colview.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lisp/org-colview.el b/lisp/org-colview.el index 1113adc..4f09766 100644 --- a/lisp/org-colview.el +++ b/lisp/org-colview.el @@ -1113,6 +1113,9 @@ display, or in the #+COLUMNS line of the current buffer." ((memq

Re: [O] [PATCH] make org-clock-time% respect org-effort-durations and related

Hello, Jan Malakhovski <o...@oxij.org> writes: > Hi. > > The first patch here is a must, because it fixes a bug I stumble upoon > daily. Middle two are just to make the names consistent. While doing > all those changes I read quite a lot of code and the last

[O] [PATCH 9/9] ob-calc: don't leave garbage on the stack

* lisp/ob-calc.el (org-babel-calc-eval-string): Clean up the stack after expression evaluation. --- lisp/ob-calc.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/ob-calc.el b/lisp/ob-calc.el index e8b43e7..2656f27 100644 --- a/lisp/ob-calc.el +++ b/lisp/ob-calc.el

[O] [PATCH 2/9] org-colview: add a FIXME

TINYCHANGE --- lisp/org-colview.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lisp/org-colview.el b/lisp/org-colview.el index b698801..d27abc3 100644 --- a/lisp/org-colview.el +++ b/lisp/org-colview.el @@ -1113,6 +1113,9 @@ display, or in the #+COLUMNS line of the current buffer."

[O] [PATCH 3/3] org-contacts: fix org-contacts-matcher for BIRTHDAYs

* contrib/lisp/org-contacts.el (org-contacts-matcher): Fix expression to work for BIRTHDAY-only contacts. --- contrib/lisp/org-contacts.el | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/contrib/lisp/org-contacts.el b/contrib/lisp/org-contacts.el index

Re: [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint

Matt Lundin <m...@imapmail.org> writes: > Jan Malakhovski <o...@oxij.org> writes: > >> I'm pretty sure that there are other org-mode users that are weeping >> silently since that change. Suppose you have more than a screen of clock >> lines in LOGBOOK under

Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props

Hi Jan, 2015ko azaroak 3an, Jan Malakhovski-ek idatzi zuen: [...] > diff --git a/lisp/org.el b/lisp/org.el > index c466870..cf0ef1f 100755 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -9960,7 +9960,7 @@ active region." >(car org-stored-links)) > >

[O] [PATCH 2/2] org-notmuch: add date support to org-notmuch-store-link

--- contrib/lisp/org-notmuch.el | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/contrib/lisp/org-notmuch.el b/contrib/lisp/org-notmuch.el index 712ec5a..265742e 100644 --- a/contrib/lisp/org-notmuch.el +++ b/contrib/lisp/org-notmuch.el @@ -71,15 +71,16 @@ Should accept

Re: [O] Bug: Regressions from 8.2.10 (8.2.10-35-g19a7d6-elpaplus) to master/maint

Jan Malakhovski <o...@oxij.org> writes: > I'm pretty sure that there are other org-mode users that are weeping > silently since that change. Suppose you have more than a screen of clock > lines in LOGBOOK under a heading (I have headings that have thousands). > (org-a

Re: [O] [PATCH 3/9] org-clock: fix `org-clock-time%'

Hi Jan, A couple stylistic comments. 2015ko azaroak 3an, Jan Malakhovski-ek idatzi zuen: > > * lisp/org-clock.el (org-clock-time%): Respect org-effort-durations. > > This also fixes a bug with time percents looking pretty much random and adding > to a number that is less than 10

[O] [PATCH 2/4] org: move org-duration-string-to-minutes to a better place

--- lisp/org.el | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index 088913c..453ed37 100755 --- a/lisp/org.el +++ b/lisp/org.el @@ -18329,6 +18329,26 @@ If no number is found, the return value is 0."

[O] [PATCH 1/4] org-clock: make org-clock-time% respect org-effort-durations

This also fixes a bug with time percents looking pretty much random and adding to a number that is less than 100% when a clock report has long intervals (e.g. days). --- lisp/org-clock.el | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git

[O] [PATCH 7/9] org-notmuch: add date support to org-notmuch-store-link

* contrib/lisp/org-notmuch.el (org-notmuch-store-link): Add date support. * doc/org.texi: Fix `org-capture-templates' documentation. --- contrib/lisp/org-notmuch.el | 7 --- doc/org.texi| 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git

[O] [PATCH 3/9] org-clock: fix `org-clock-time%'

* lisp/org-clock.el (org-clock-time%): Respect org-effort-durations. This also fixes a bug with time percents looking pretty much random and adding to a number that is less than 100% when a clock report has long intervals (e.g. days). --- lisp/org-clock.el | 29 +++-- 1

[O] [PATCH 4/9] org: move `org-duration-string-to-minutes' to a better place

--- lisp/org.el | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index 6218a3a..a0fe644 100755 --- a/lisp/org.el +++ b/lisp/org.el @@ -18328,6 +18328,26 @@ If no number is found, the return value is 0."

[O] [PATCH 2/2] org-notmuch: add date support to org-notmuch-store-link

* contrib/lisp/org-notmuch.el (org-notmuch-store-link): Add date support. * doc/org.texi: Fix `org-capture-templates' documentation. --- contrib/lisp/org-notmuch.el | 7 --- doc/org.texi| 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git

[O] [PATCH 1/4] org: move `org-duration-string-to-minutes' to a better place

--- lisp/org.el | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index 74d1c4c..f6c513e 100755 --- a/lisp/org.el +++ b/lisp/org.el @@ -18303,6 +18303,26 @@ If no number is found, the return value is 0."

[O] [PATCH 4/4] org-clock: make clock table respect `org-effort-durations'

* lisp/org-clock.el (org-clock-time%): Rewrite using (org-clocksum-string-to-minutes), document pitfalls. (org-clock-time%-with-effort): New function. (org-clocktable-write-default): Fix effort-duration parameter. * doc/org.texi (The clock table): Update documentation. --- doc/org.texi | 6

Re: [O] [PATCH 5/9] rename `org-duration-string-to-minutes' to `org-clocksum-string-to-minutes' everywhere

Hi Jan, 2015ko azaroak 3an, Jan Malakhovski-ek idatzi zuen: > > * lisp/org-agenda.el: > * lisp/org-clock.el: > * lisp/org-colview.el: > * lisp/org.el: > * contrib/lisp/org-depend.el: > * contrib/lisp/ox-taskjuggler.el: Rename (org-duration-string-to-minutes) >

[O] [PATCH 3/4] rename org-duration-string-to-minutes to org-clocksum-string-to-minutes everywhere

--- contrib/lisp/org-depend.el | 2 +- contrib/lisp/ox-taskjuggler.el | 2 +- lisp/org-agenda.el | 2 +- lisp/org-clock.el | 14 +++--- lisp/org-colview.el| 2 +- lisp/org.el| 14 +- 6 files changed, 20

[O] [PATCH 5/9] rename `org-duration-string-to-minutes' to `org-clocksum-string-to-minutes' everywhere

* lisp/org-agenda.el: * lisp/org-clock.el: * lisp/org-colview.el: * lisp/org.el: * contrib/lisp/org-depend.el: * contrib/lisp/ox-taskjuggler.el: Rename (org-duration-string-to-minutes) to (org-clocksum-string-to-minutes). --- contrib/lisp/org-depend.el | 2 +-

[O] [PATCH 2/4] rename `org-duration-string-to-minutes' to `org-clocksum-string-to-minutes' everywhere

* lisp/org-agenda.el: * lisp/org-clock.el: * lisp/org-colview.el: * lisp/org.el: * contrib/lisp/org-depend.el: * contrib/lisp/ox-taskjuggler.el: Rename (org-duration-string-to-minutes) to (org-clocksum-string-to-minutes). --- contrib/lisp/org-depend.el | 2 +-

[O] [PATCH 1/2] factor out date-timestamp* calculations to org-store-link-props

--- contrib/lisp/org-mew.el | 11 +-- contrib/lisp/org-vm.el | 11 +-- contrib/lisp/org-wl.el | 10 +- doc/org.texi| 4 ++-- lisp/org-gnus.el| 15 +-- lisp/org-mhe.el | 10 +- lisp/org-rmail.el | 11 +--

[O] [PATCH 8/9] ob-calc: add more API, documentation and examples so that it can be used in tables

* lisp/ob-calc.el (org-babel-calc-eval): (org-babel-calc-set-env): (org-babel-calc-reset-env): (org-babel-calc-store-env): (org-babel-calc-eval-string): (org-babel-calc-eval-line): New funcion. (org-babel-execute:calc): Rewrite to use new functions. This also makes ob-calc useful for computing

[O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props

* lisp/org.el (org-store-link-props): Rewrite function to get date-timestamp* calculations. * lisp/org-gnus.el: * lisp/org-mhe.el: * lisp/org-rmail.el: * contrib/lisp/org-mew.el: * contrib/lisp/org-vm.el: * contrib/lisp/org-wl.el: Remove date-timestamp* copy-paste. * doc/org.texi: Fix

[O] [PATCH 1/2] factor out date-timestamp* calculations to org-store-link-props

* lisp/org.el (org-store-link-props): Rewrite function to get date-timestamp* calculations. * lisp/org-gnus.el: * lisp/org-mhe.el: * lisp/org-rmail.el: * contrib/lisp/org-mew.el: * contrib/lisp/org-vm.el: * contrib/lisp/org-wl.el: Remove date-timestamp* copy-paste. * doc/org.texi: Fix

[O] [PATCH 3/4] simplify and document `org-effort-durations'-related code

* lisp/org.el (org-time-clocksum-use-effort-durations): Make obsolete. (org-effort-durations-default): (org-effort-durations-8h): (org-effort-durations-6h): New constants. (org-effort-durations): Redefine and document. (org-minutes-to-clocksum-string): Simplify. * lisp/org-agenda.el: