AT91SAM9M10: Problem porting driver for MT9P031 sensor

2013-04-18 Thread Marcio Campos de Lima
Hi I am porting the MT9P031 sensor device driver for a custom designed board based at the AT91SAM9M45-EK development board and Linux 3.6.9. The driver detects the sensor but does not create /dev/video1. Can anybody help me? Thanks Marcio This is the probe code fo the driver if this can help

Re: [PATCH] mt9p031: Aptina (Micron) MT9P031 5MP sensor driver

2011-07-27 Thread Laurent Pinchart
mt9p031_platform_data *pdata = client-dev.platform_data; + struct i2c_adapter *adapter = to_i2c_adapter(client-dev.parent); + struct mt9p031 *mt9p031; + unsigned int i; + int ret; + + if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_WORD_DATA)) { + dev_warn(adapter

[PATCH] mt9p031: Use bulk regulator API

2013-06-10 Thread Laurent Pinchart
--- drivers/media/i2c/mt9p031.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) Changes since v1: - Return the devm_regulator_bulk_get() return code instead of -ENODEV diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c index 6187416..c93640b

[PATCH 2/3] mt9p031: Replace the reset board callback by a GPIO number

2012-04-29 Thread Laurent Pinchart
Use the GPIO from the sensor driver instead of calling back to board code. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mt9p031.c | 29 +++-- include/media/mt9p031.h | 13 ++--- 2 files changed, 33 insertions

[PATCH] mt9p031: Use bulk regulator API

2013-06-08 Thread Laurent Pinchart
--- drivers/media/i2c/mt9p031.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c index 6187416..2a71a0d 100644 --- a/drivers/media/i2c/mt9p031.c +++ b/drivers/media/i2c/mt9p031.c @@ -126,9 +126,7

[PATCH] mt9p031: Add support for core and I/O regulators

2012-05-08 Thread Laurent Pinchart
The regulators are optional. If present, enable them when powering the sensor up, and disable them when powering it down. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mt9p031.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions

[PATCH 2/2] mt9p031: Use the common clock framework

2013-04-04 Thread Laurent Pinchart
Configure the device external clock using the common clock framework instead of a board code callback function. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/mt9p031.c | 22 +++--- include/media/mt9p031.h | 2 -- 2 files changed, 15

[PATCH v2 2/2] mt9p031: Use the common clock framework

2013-04-04 Thread Laurent Pinchart
Configure the device external clock using the common clock framework instead of a board code callback function. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/mt9p031.c | 22 +++--- include/media/mt9p031.h | 2 -- 2 files changed, 15

[PATCH] mt9p031: Use gpio_is_valid()

2013-05-02 Thread Laurent Pinchart
Replace the manual validity checks for the reset GPIO with the gpio_is_valid() function. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/mt9p031.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/mt9p031.c b

Re: [PATCH] mt9p031: Use gpio_is_valid()

2013-05-02 Thread Sylwester Nawrocki
On 05/02/2013 01:04 PM, Laurent Pinchart wrote: Replace the manual validity checks for the reset GPIO with the gpio_is_valid() function. Signed-off-by: Laurent Pinchartlaurent.pinch...@ideasonboard.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com --- drivers/media/i2c/mt9p031.c

[PATCH 16/24] V4L2: mt9p031: add support for V4L2 clock and asynchronous probing

2013-04-18 Thread Guennadi Liakhovetski
This adds support for V4L2 clock and asynchronous subdevice probing. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c/mt9p031.c | 31 +-- 1 files changed, 29 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/mt9p031.c b

[RFC PATCH] media: i2c: mt9p031: Add 8-bit support

2017-07-18 Thread Adam Ford
gicpd.com> diff --git a/Documentation/devicetree/bindings/media/i2c/mt9p031.txt b/Documentation/devicetree/bindings/media/i2c/mt9p031.txt index cb60443..77b0dc1 100644 --- a/Documentation/devicetree/bindings/media/i2c/mt9p031.txt +++ b/Documentation/devicetree/bindings/media/i2c/mt9p031.txt @@

[PATCH v2] media: i2c: mt9p031: Check return value of clk_prepare_enable/clk_set_rate

2014-01-20 Thread Prabhakar Lad
/media/i2c/mt9p031.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c index e5ddf47..05278f5 100644 --- a/drivers/media/i2c/mt9p031.c +++ b/drivers/media/i2c/mt9p031.c @@ -222,12 +222,15 @@ static int

Re: [PATCH v2] media: i2c: mt9p031: Check return value of clk_prepare_enable/clk_set_rate

2014-01-21 Thread Laurent Pinchart
prabhakar.cse...@gmail.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com and applied to my tree. --- Changes for v2: 1: Called regulator_bulk_disable() in the error path drivers/media/i2c/mt9p031.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff

Re: AT91SAM9M10: Problem porting driver for MT9P031 sensor

2013-04-18 Thread Guennadi Liakhovetski
Hi Marcio On Thu, 18 Apr 2013, Marcio Campos de Lima wrote: Hi I am porting the MT9P031 sensor device driver for a custom designed board based at the AT91SAM9M45-EK development board and Linux 3.6.9. The driver detects the sensor but does not create /dev/video1. Can anybody help me

[PATCH] mt9p031: Add support for regulators

2013-01-02 Thread Laurent Pinchart
/i2c/mt9p031.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c index e0bad59..ecf4492 100644 --- a/drivers/media/i2c/mt9p031.c +++ b/drivers/media/i2c/mt9p031.c @@ -19,6 +19,7 @@ #include linux

[PATCH] v4l: mt9p031: Convert to the gpiod API

2015-03-08 Thread Laurent Pinchart
This simplifies platform data and DT integration. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/mt9p031.c | 31 +++ include/media/mt9p031.h | 2 -- 2 files changed, 11 insertions(+), 22 deletions(-) diff --git a/drivers

[PATCH] mt9p031: Do not use PLL if external frequency is the same as target frequency.

2011-09-06 Thread Javier Martin
This patch adds a check to see whether ext_freq and target_freq are equal and, if true, PLL won't be used. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/mt9p031.c | 18 +++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git

[PATCH] media: i2c: mt9p031: Check return value of clk_prepare_enable/clk_set_rate

2014-01-17 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com clk_set_rate(), clk_prepare_enable() functions can fail, so check the return values to avoid surprises. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/media/i2c/mt9p031.c | 12 +--- 1 file changed, 9 insertions

Re: [PATCH] media: i2c: mt9p031: Check return value of clk_prepare_enable/clk_set_rate

2014-01-19 Thread Laurent Pinchart
prabhakar.cse...@gmail.com --- drivers/media/i2c/mt9p031.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c index e5ddf47..dbe34d7 100644 --- a/drivers/media/i2c/mt9p031.c +++ b/drivers/media/i2c/mt9p031.c

[PATCH 4/5] mt9p031: Fix typo in comment

2014-02-10 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/mt9p031.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c index 05278f5..14a616e 100644 --- a/drivers/media/i2c/mt9p031.c +++ b

[PATCH 1/3] mt9p031: Identify color/mono models using I2C device name

2012-04-29 Thread Laurent Pinchart
Instead of passing a color/monochrome flag through platform data, rely on the I2C device name to identify the chip model. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mt9p031.c | 14 +++--- include/media/mt9p031.h |6 -- 2

Re: [PATCH] mt9p031: Aptina (Micron) MT9P031 5MP sensor driver

2011-07-27 Thread Sylwester Nawrocki
Hi Laurent, Javier, On 07/27/2011 11:13 AM, Laurent Pinchart wrote: From: Javier Martinjavier.mar...@vista-silicon.com The MT9P031 is a parallel 12-bit 5MP sensor from Aptina (formerly Micron) controlled through I2C. The driver creates a V4L2 subdevice. It currently supports skipping

[PATCH] mt9p031: Use devm_* managed helpers

2013-01-02 Thread Laurent Pinchart
Replace kzalloc and gpio_request_one by their managed equivalents. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/mt9p031.c | 13 +++-- 1 files changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media

[PATCH 5/5] mt9p031: Add support for PLL bypass

2014-02-10 Thread Laurent Pinchart
When the input clock frequency is out of bounds for the PLL, bypass the PLL and just divide the input clock to achieve the requested output frequency. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/mt9p031.c | 32 1 file

[PATCH] mt9p031: Fix BLC configuration restore when disabling test pattern

2014-05-08 Thread Laurent Pinchart
value. Fix this by writing to the registers directly. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/mt9p031.c | 36 ++-- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/drivers/media/i2c/mt9p031.c b/drivers

Re: [PATCH] v4l: mt9p031: Convert to the gpiod API

2015-03-10 Thread Lad, Prabhakar
Hi Laurent, Thanks for the patch. On Sun, Mar 8, 2015 at 1:40 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: This simplifies platform data and DT integration. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/mt9p031.c | 31

Re: [RFC PATCH] media: i2c: mt9p031: Add 8-bit support

2017-07-18 Thread Laurent Pinchart
t; resolution. Tested on Logic PD DM3730 Torpedo Development Kit. I don't think that's right. The MT9P031 can't output 8-bit data. What can be done, of course, is connect only the topmost 8 bits of the 12-bit output to an 8-bit input on a receiver. That supported through the data-shift propert

[PATCH] media: i2c: mt9p031: make sure we destroy the mutex

2015-02-26 Thread Lad Prabhakar
From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch makes sure to call mutex_destroy() in case of probe failure or module unload. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/media/i2c/mt9p031.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] media: i2c: mt9p031: make sure we destroy the mutex

2015-02-26 Thread Laurent Pinchart
...@gmail.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com and applied to my tree with a slightly modified commit message: Make sure to call mutex_destroy() in case of probe failure or module unload. --- drivers/media/i2c/mt9p031.c | 5 - 1 file changed, 4 insertions(+), 1

[PATCH][RFC] Add mt9p031 sensor support.

2011-05-24 Thread Javier Martin
/video/Makefile |1 + drivers/media/video/mt9p031.c | 841 + include/media/mt9p031.h | 11 + 4 files changed, 860 insertions(+), 0 deletions(-) create mode 100644 drivers/media/video/mt9p031.c create mode 100644 include/media/mt9p031.h diff

[RFC v3 1/2] Add mt9p031 sensor driver.

2011-05-26 Thread Javier Martin
management is. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/Kconfig |7 + drivers/media/video/Makefile |1 + drivers/media/video/mt9p031.c | 841 + include/media/mt9p031.h | 11 + 4 files changed

Re: AT91SAM9M10: Problem porting driver for MT9P031 sensor

2013-04-18 Thread Marcio Campos de Lima
Hi Guennadi Thanks a lot for your attention. I think I cannot apply the patches. My Linux sources, downloaded from www.at91.com, does not have the V4l2-async.h header and, I suppose, many others headers. The MT9P031 sources have been modified and it is in a different tree. Can you tell me where I

Re: AT91SAM9M10: Problem porting driver for MT9P031 sensor

2013-04-19 Thread Guennadi Liakhovetski
On Thu, 18 Apr 2013, Marcio Campos de Lima wrote: Hi Guennadi Thanks a lot for your attention. I think I cannot apply the patches. My Linux sources, downloaded from www.at91.com, does not have the V4l2-async.h header and, I suppose, many others headers. The MT9P031 sources have been

Re: AT91SAM9M10: Problem porting driver for MT9P031 sensor

2013-04-19 Thread Marcio Lima
, downloaded from www.at91.com, does not have the V4l2-async.h header and, I suppose, many others headers. The MT9P031 sources have been modified and it is in a different tree. Can you tell me where I can download an already patched Kernel 3.6.9 which I can add theses functionality to the driver I am

Re: AT91SAM9M10: Problem porting driver for MT9P031 sensor

2013-04-19 Thread Guennadi Liakhovetski
the V4l2-async.h header and, I suppose, many others headers. The MT9P031 sources have been modified and it is in a different tree. Can you tell me where I can download an already patched Kernel 3.6.9 which I can add theses functionality to the driver I am using? Hm, no, sorry, today isn't your

Re: AT91SAM9M10: Problem porting driver for MT9P031 sensor

2013-04-23 Thread Marcio Campos de Lima
. I think I cannot apply the patches. My Linux sources, downloaded from www.at91.com, does not have the V4l2-async.h header and, I suppose, many others headers. The MT9P031 sources have been modified and it is in a different tree. Can you tell me where I can download an already patched Kernel

Re: [PATCH] mt9p031: Add support for regulators

2013-01-02 Thread Guennadi Liakhovetski
Guennadi Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/mt9p031.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c index e0bad59..ecf4492 100644

Re: [PATCH] mt9p031: Do not use PLL if external frequency is the same as target frequency.

2011-09-06 Thread Laurent Pinchart
instead of using a table of hardcoded values ? :-) Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/mt9p031.c | 18 +++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/mt9p031.c b/drivers/media/video

Re: [PATCH] mt9p031: Use bulk regulator API

2013-06-08 Thread Fabio Estevam
On Sat, Jun 8, 2013 at 10:20 AM, Fabio Estevam feste...@gmail.com wrote: On Sat, Jun 8, 2013 at 4:55 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: - if (IS_ERR(mt9p031-vaa) || IS_ERR(mt9p031-vdd) || - IS_ERR(mt9p031-vdd_io)) { + ret

Re: [PATCH] mt9p031: Aptina (Micron) MT9P031 5MP sensor driver

2011-07-27 Thread Laurent Pinchart
, Laurent Pinchart wrote: [snip] +static struct mt9p031 *to_mt9p031(struct v4l2_subdev *sd) +{ + return container_of(sd, struct mt9p031, subdev); +} + +static int mt9p031_read(struct i2c_client *client, u8 reg) +{ + s32 data = i2c_smbus_read_word_data(client, reg); + return data

[PATCH v2] [media] mt9p031: fixed calculation of clk_div

2015-02-04 Thread Enrico Scholz
There must be used 'min_t', not 'max_t' for calculating the divider. Signed-off-by: Enrico Scholz enrico.sch...@sigma-chemnitz.de Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/mt9p031.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] [media] mt9p031: fixed calculation of clk_div

2015-02-04 Thread Enrico Scholz
There must be used 'min_t', not 'max_t' for calculating the divider and the upper limit is '63' (value uses 6:0 register bits). Signed-off-by: Enrico Scholz enrico.sch...@sigma-chemnitz.de Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/mt9p031.c | 2 +- 1 file

Re: [PATCH v2] [media] mt9p031: fixed calculation of clk_div

2015-02-05 Thread Laurent Pinchart
-by: Laurent Pinchart laurent.pinch...@ideasonboard.com and applied to my tree. I'll send a pull request for v3.21. --- drivers/media/i2c/mt9p031.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c index 0cabf91

[PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-20 Thread Javier Martin
This driver adds basic support for Aptina mt9p031 sensor. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/Kconfig |8 + drivers/media/video/Makefile |1 + drivers/media/video/mt9p031.c | 751 + include/media

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-21 Thread Mauro Carvalho Chehab
basic support for Aptina mt9p031 sensor. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/Kconfig |8 + drivers/media/video/Makefile |1 + drivers/media/video/mt9p031.c | 751 + include/media/mt9p031

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-21 Thread Guennadi Liakhovetski
On Fri, 20 May 2011, Javier Martin wrote: This driver adds basic support for Aptina mt9p031 sensor. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/Kconfig |8 + drivers/media/video/Makefile |1 + drivers/media/video/mt9p031.c | 751

[PATCH] Second RFC version of mt9p031 sensor with power managament.

2011-05-25 Thread Javier Martin
details to fix but I would like someone could help in the power management issue. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/Kconfig |7 + drivers/media/video/Makefile |1 + drivers/media/video/mt9p031.c | 752

[PATCH 4/5] mt9p031: Use generic PLL setup code

2012-03-06 Thread Laurent Pinchart
Compute the PLL parameters at runtime using the generic Aptina PLL helper. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/Kconfig |1 + drivers/media/video/mt9p031.c | 62 ++--- 2 files changed, 28 insertions

[PATCH v2 4/5] mt9p031: Use generic PLL setup code

2012-03-06 Thread Laurent Pinchart
Compute the PLL parameters at runtime using the generic Aptina PLL helper. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/Kconfig |1 + drivers/media/video/mt9p031.c | 62 ++--- 2 files changed, 28 insertions

[PATCH v3 4/5] mt9p031: Use generic PLL setup code

2012-03-06 Thread Laurent Pinchart
Compute the PLL parameters at runtime using the generic Aptina PLL helper. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/Kconfig |1 + drivers/media/video/mt9p031.c | 62 ++--- 2 files changed, 28 insertions

[PATCH v4 4/5] mt9p031: Use generic PLL setup code

2012-03-09 Thread Laurent Pinchart
Compute the PLL parameters at runtime using the generic Aptina PLL helper. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/Kconfig |1 + drivers/media/video/mt9p031.c | 62

[PATCH 0/3] MT9P031 sensor driver fixes

2012-04-29 Thread Laurent Pinchart
Hi everybody, Here are 3 small patches for the MT9P031 sensor driver. I plan to push them for v3.5. Laurent Pinchart (3): mt9p031: Identify color/mono models using I2C device name mt9p031: Replace the reset board callback by a GPIO number mt9p031: Implement black level compensation control

[PATCH] mt9p031: Remove unused xskip and yskip fields in struct mt9p031

2012-01-30 Thread Laurent Pinchart
The fields are set but never used, remove them. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mt9p031.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/mt9p031.c b/drivers/media/video/mt9p031.c index

[PATCH 2/5] mt9p031: Remove unused xskip and yskip fields in struct mt9p031

2012-03-06 Thread Laurent Pinchart
The fields are set but never used, remove them. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mt9p031.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/mt9p031.c b/drivers/media/video/mt9p031.c index

[PATCH v2 2/5] mt9p031: Remove unused xskip and yskip fields in struct mt9p031

2012-03-06 Thread Laurent Pinchart
The fields are set but never used, remove them. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mt9p031.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/mt9p031.c b/drivers/media/video/mt9p031.c index

[PATCH v3 2/5] mt9p031: Remove unused xskip and yskip fields in struct mt9p031

2012-03-06 Thread Laurent Pinchart
The fields are set but never used, remove them. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mt9p031.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/mt9p031.c b/drivers/media/video/mt9p031.c index

[PATCH v4 2/5] mt9p031: Remove unused xskip and yskip fields in struct mt9p031

2012-03-09 Thread Laurent Pinchart
The fields are set but never used, remove them. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Reviewed-by: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/mt9p031.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/media/video

[PATCH 17/24] V4L2: mt9p031: add support for .g_mbus_config() video operation

2013-04-18 Thread Guennadi Liakhovetski
.g_mbus_config() subdevice video operation is required for subdevice drivers to be used with the soc-camera framework. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c/mt9p031.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git

[PATCH v6 1/2] Add driver for Aptina (Micron) mt9p031 sensor.

2011-06-01 Thread Javier Martin
+ drivers/media/video/Makefile |1 + drivers/media/video/mt9p031.c | 763 + include/media/mt9p031.h | 23 ++ 4 files changed, 794 insertions(+), 0 deletions(-) create mode 100644 drivers/media/video/mt9p031.c create mode 100644 include/media/mt9p031.h

Re: [PATCH v6 1/2] Add driver for Aptina (Micron) mt9p031 sensor.

2011-06-02 Thread Guennadi Liakhovetski
to select one of them is through platform data. Internal PLL is now used to generate PIXCLK depending on VDD_IO. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/Kconfig |7 + drivers/media/video/Makefile |1 + drivers/media/video/mt9p031.c

[PATCH v7 1/2] Add driver for Aptina (Micron) mt9p031 sensor.

2011-06-02 Thread Javier Martin
This version fixes some cosmetic issues pointed out by Guennadi. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/Kconfig |7 + drivers/media/video/Makefile |1 + drivers/media/video/mt9p031.c | 763

Re: [PATCH] mt9p031: Use bulk regulator API

2013-06-08 Thread Fabio Estevam
On Sat, Jun 8, 2013 at 4:55 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: - if (IS_ERR(mt9p031-vaa) || IS_ERR(mt9p031-vdd) || - IS_ERR(mt9p031-vdd_io)) { + ret = devm_regulator_bulk_get(client-dev, 3, mt9p031-regulators); + if (ret 0

[PATCH v4 1/2] Add support for mt9p031 Aptina (Micron) sensor.

2011-05-30 Thread Javier Martin
This patch adds basic support (no controls) for mt9p031 sensor. It applies on kernel 2.6.39. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/Kconfig |7 + drivers/media/video/Makefile |1 + drivers/media/video/mt9p031.c | 699

[PATCH v5 1/2] Add support for mt9p031 Aptina (Micron) sensor.

2011-05-31 Thread Javier Martin
This patch adds basic support (no controls) for mt9p031 sensor. It applies on kernel 2.6.39. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/Kconfig |7 + drivers/media/video/Makefile |1 + drivers/media/video/mt9p031.c | 699

[PATCH 23/24] V4L2: mt9p031: add struct v4l2_subdev_platform_data to platform data

2013-04-18 Thread Guennadi Liakhovetski
Adding struct v4l2_subdev_platform_data to mt9p031's platform data allows the driver to use generic functions to manage sensor power supplies. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c/mt9p031.c |1 + include/media/mt9p031.h |3 +++ 2 files

Re: [PATCH 23/24] V4L2: mt9p031: add struct v4l2_subdev_platform_data to platform data

2013-04-18 Thread Guennadi Liakhovetski
On Thu, 18 Apr 2013, Guennadi Liakhovetski wrote: Adding struct v4l2_subdev_platform_data to mt9p031's platform data allows the driver to use generic functions to manage sensor power supplies. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de A small addition to this one too

[PATCH 1/2] mt9p031: Add mt9p031 sensor driver.

2011-05-17 Thread Javier Martin
It has been tested in beagleboard xM, using LI-5M03 module. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/Kconfig |8 + drivers/media/video/Makefile|1 + drivers/media/video/mt9p031.c | 773 +++ include

Re: [PATCH][RFC] Add mt9p031 sensor support.

2011-05-25 Thread Laurent Pinchart
on the image randomly). Signed-off-by: Javier Martin javier.mar...@vista-silicon.com [snip] diff --git a/drivers/media/video/mt9p031.c b/drivers/media/video/mt9p031.c new file mode 100644 index 000..04d8812 --- /dev/null +++ b/drivers/media/video/mt9p031.c [snip] @@ -0,0 +1,841

[PATCH 2/3] mt9p031: Implement V4L2_CID_PIXEL_RATE control

2012-05-09 Thread Laurent Pinchart
The pixel rate control is required by the OMAP3 ISP driver and should be implemented by all media controller-compatible sensor drivers. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mt9p031.c |5 - 1 files changed, 4 insertions(+), 1 deletions

Re: [PATCH] media: i2c: mt9p031: add support for asynchronous probing

2015-03-08 Thread Laurent Pinchart
Hi Prabhakar, Thank you for the patch. On Friday 27 February 2015 16:10:19 Lad Prabhakar wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com Both synchronous and asynchronous mt9p031 subdevice probing is supported by this patch. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com

[PATCH] media: i2c: mt9p031: add support for asynchronous probing

2015-02-27 Thread Lad Prabhakar
From: Lad, Prabhakar prabhakar.cse...@gmail.com Both synchronous and asynchronous mt9p031 subdevice probing is supported by this patch. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/media/i2c/mt9p031.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff

Re: [PATCH] mt9p031: Use bulk regulator API

2013-06-10 Thread Laurent Pinchart
Hi Fabio, On Saturday 08 June 2013 10:24:58 Fabio Estevam wrote: On Sat, Jun 8, 2013 at 10:20 AM, Fabio Estevam wrote: On Sat, Jun 8, 2013 at 4:55 AM, Laurent Pinchart wrote: - if (IS_ERR(mt9p031-vaa) || IS_ERR(mt9p031-vdd) || - IS_ERR(mt9p031-vdd_io)) { + ret

Re: [PATCH 23/24] V4L2: mt9p031: add struct v4l2_subdev_platform_data to platform data

2013-04-22 Thread Laurent Pinchart
Hi Guennadi, On Thursday 18 April 2013 23:35:44 Guennadi Liakhovetski wrote: Adding struct v4l2_subdev_platform_data to mt9p031's platform data allows the driver to use generic functions to manage sensor power supplies. The mt9p031 driver now handles its regulators explicitly, please see

[PATCH 18/24] V4L2: mt9p031: power down the sensor if no supported device has been detected

2013-04-18 Thread Guennadi Liakhovetski
The mt9p031 driver first accesses the I2C device in its .registered() method. While doing that it furst powers the device up, but if probing fails, it doesn't power the chip back down. This patch fixes that bug. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- drivers/media/i2c

Re: [PATCH] v4l: mt9p031: Convert to the gpiod API

2015-03-11 Thread Lad, Prabhakar
-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/mt9p031.c | 31 +++ include/media/mt9p031.h | 2 -- 2 files changed, 11 insertions(+), 22 deletions(-) diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031

Re: [PATCH] v4l: mt9p031: Convert to the gpiod API

2015-03-11 Thread Laurent Pinchart
Hi Prabhakar, On Tuesday 10 March 2015 18:29:22 Lad, Prabhakar wrote: On Sun, Mar 8, 2015 at 1:40 PM, Laurent Pinchart wrote: This simplifies platform data and DT integration. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/i2c/mt9p031.c | 31

Re: Current status report of mt9p031.

2011-05-10 Thread Laurent Pinchart
Hi Javier, On Tuesday 10 May 2011 09:31:02 javier Martin wrote: On 5 May 2011 18:55, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Javier, Here's the review of 0002-mt9p031.patch. [snip] +static int mt9p031_probe(struct i2c_client *client

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-23 Thread javier Martin
On 21 May 2011 17:29, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Fri, 20 May 2011, Javier Martin wrote: This driver adds basic support for Aptina mt9p031 sensor. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com ---  drivers/media/video/Kconfig   |    8 +  drivers

[PATCH] mt9p031.c included media/v4l2-subdev.h twice

2012-02-15 Thread Danny Kukawka
drivers/media/video/mt9p031.c included 'media/v4l2-subdev.h' twice, remove the duplicate. Signed-off-by: Danny Kukawka danny.kuka...@bisect.de --- drivers/media/video/mt9p031.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/mt9p031.c b/drivers/media

Re: [PATCH] mt9p031.c included media/v4l2-subdev.h twice

2012-02-15 Thread Laurent Pinchart
Hi Danny, Thanks for the patch. On Wednesday 15 February 2012 20:20:55 Danny Kukawka wrote: drivers/media/video/mt9p031.c included 'media/v4l2-subdev.h' twice, remove the duplicate. Signed-off-by: Danny Kukawka danny.kuka...@bisect.de Acked-by: Laurent Pinchart laurent.pinch

[PATCH 1/5] mt9p031: Remove duplicate media/v4l2-subdev.h include

2012-03-06 Thread Laurent Pinchart
From: Danny Kukawka danny.kuka...@bisect.de drivers/media/video/mt9p031.c included 'media/v4l2-subdev.h' twice, remove the duplicate. Signed-off-by: Danny Kukawka danny.kuka...@bisect.de Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mt9p031.c |1 - 1

[PATCH v2 1/5] mt9p031: Remove duplicate media/v4l2-subdev.h include

2012-03-06 Thread Laurent Pinchart
From: Danny Kukawka danny.kuka...@bisect.de drivers/media/video/mt9p031.c included 'media/v4l2-subdev.h' twice, remove the duplicate. Signed-off-by: Danny Kukawka danny.kuka...@bisect.de Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mt9p031.c |1 - 1

[PATCH v3 1/5] mt9p031: Remove duplicate media/v4l2-subdev.h include

2012-03-06 Thread Laurent Pinchart
From: Danny Kukawka danny.kuka...@bisect.de drivers/media/video/mt9p031.c included 'media/v4l2-subdev.h' twice, remove the duplicate. Signed-off-by: Danny Kukawka danny.kuka...@bisect.de Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mt9p031.c |1 - 1

[PATCH v4 1/5] mt9p031: Remove duplicate media/v4l2-subdev.h include

2012-03-09 Thread Laurent Pinchart
From: Danny Kukawka danny.kuka...@bisect.de drivers/media/video/mt9p031.c included 'media/v4l2-subdev.h' twice, remove the duplicate. Signed-off-by: Danny Kukawka danny.kuka...@bisect.de Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/mt9p031.c |1 - 1

Re: Current status report of mt9p031.

2011-05-10 Thread javier Martin
On 5 May 2011 18:55, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Javier, Here's the review of 0002-mt9p031.patch. [snip] +static int mt9p031_probe(struct i2c_client *client, +                      const struct i2c_device_id *did) +{ +     struct mt9p031 *mt9p031

[PATCH] mt9p031: Aptina (Micron) MT9P031 5MP sensor driver

2011-07-27 Thread Laurent Pinchart
From: Javier Martin javier.mar...@vista-silicon.com The MT9P031 is a parallel 12-bit 5MP sensor from Aptina (formerly Micron) controlled through I2C. The driver creates a V4L2 subdevice. It currently supports skipping, cropping, automatic binning, and gain, exposure, h/v flip and test pattern

Re: [PATCH] mt9p031: Aptina (Micron) MT9P031 5MP sensor driver

2011-07-27 Thread Sakari Ailus
Hi Laurent, Thanks for the patch. I have a few comments below. On Wed, Jul 27, 2011 at 11:13:01AM +0200, Laurent Pinchart wrote: From: Javier Martin javier.mar...@vista-silicon.com The MT9P031 is a parallel 12-bit 5MP sensor from Aptina (formerly Micron) controlled through I2C

[PATCH v2] mt9p031: Aptina (Micron) MT9P031 5MP sensor driver

2011-07-31 Thread Laurent Pinchart
From: Javier Martin javier.mar...@vista-silicon.com The MT9P031 is a parallel 12-bit 5MP sensor from Aptina (formerly Micron) controlled through I2C. The driver creates a V4L2 subdevice. It currently supports skipping, cropping, automatic binning, and gain, exposure, h/v flip and test pattern

Re: AT91SAM9M10: Problem porting driver for MT9P031 sensor

2013-04-23 Thread Guennadi Liakhovetski
Hi Marcio On Tue, 23 Apr 2013, Marcio Campos de Lima wrote: Hi Guennadi What is the Linux version that has all of your patches already applied? Where can I download it? You can pull the tmp-mt9p031-dontuse branch of git://linuxtv.org/gliakhovetski/v4l-dvb.git I'd be grateful if you let

Re: AT91SAM9M10: Problem porting driver for MT9P031 sensor

2013-04-23 Thread Marcio Lima
...@gmx.de escreveu: Hi Marcio On Tue, 23 Apr 2013, Marcio Campos de Lima wrote: Hi Guennadi What is the Linux version that has all of your patches already applied? Where can I download it? You can pull the tmp-mt9p031-dontuse branch of git://linuxtv.org/gliakhovetski/v4l-dvb.git I'd

Re: [PATCH 1/2] mt9p031: Add mt9p031 sensor driver.

2011-05-17 Thread Laurent Pinchart
Hi Javier, Thanks for the patch. On Tuesday 17 May 2011 11:28:47 Javier Martin wrote: It has been tested in beagleboard xM, using LI-5M03 module. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com [snip] diff --git a/drivers/media/video/mt9p031.c b/drivers/media/video/mt9p031.c

[PATCH v8 1/2] Add driver for Aptina Micron mt9p031 sensor.

2011-06-20 Thread Javier Martin
and desired freq. Signed-off-by: Javier Martin javier.mar...@vista-silicon.com --- drivers/media/video/Kconfig |7 + drivers/media/video/Makefile |1 + drivers/media/video/mt9p031.c | 928 + include/media/mt9p031.h | 19 + 4 files changed

Re: [PATCH 18/24] V4L2: mt9p031: power down the sensor if no supported device has been detected

2013-04-22 Thread Laurent Pinchart
Hi Guennadi, Thanks for the patch. On Thursday 18 April 2013 23:35:39 Guennadi Liakhovetski wrote: The mt9p031 driver first accesses the I2C device in its .registered() method. While doing that it furst powers the device up, but if probing s/furst/first/ fails, it doesn't power the chip

Re: [PATCH 18/24] V4L2: mt9p031: power down the sensor if no supported device has been detected

2013-04-22 Thread Guennadi Liakhovetski
Hi Laurent On Mon, 22 Apr 2013, Laurent Pinchart wrote: Hi Guennadi, Thanks for the patch. On Thursday 18 April 2013 23:35:39 Guennadi Liakhovetski wrote: The mt9p031 driver first accesses the I2C device in its .registered() method. While doing that it furst powers the device up

Re: [PATCH 23/24] V4L2: mt9p031: add struct v4l2_subdev_platform_data to platform data

2013-04-22 Thread Laurent Pinchart
Hi Guennadi, On Thursday 18 April 2013 23:47:26 Guennadi Liakhovetski wrote: On Thu, 18 Apr 2013, Guennadi Liakhovetski wrote: Adding struct v4l2_subdev_platform_data to mt9p031's platform data allows the driver to use generic functions to manage sensor power supplies. Signed-off

Re: [PATCH 23/24] V4L2: mt9p031: add struct v4l2_subdev_platform_data to platform data

2013-04-22 Thread Guennadi Liakhovetski
On Mon, 22 Apr 2013, Laurent Pinchart wrote: Hi Guennadi, On Thursday 18 April 2013 23:47:26 Guennadi Liakhovetski wrote: On Thu, 18 Apr 2013, Guennadi Liakhovetski wrote: Adding struct v4l2_subdev_platform_data to mt9p031's platform data allows the driver to use generic functions

Re: [PATCH 23/24] V4L2: mt9p031: add struct v4l2_subdev_platform_data to platform data

2013-04-22 Thread Laurent Pinchart
On Monday 22 April 2013 14:39:57 Guennadi Liakhovetski wrote: On Mon, 22 Apr 2013, Laurent Pinchart wrote: On Thursday 18 April 2013 23:47:26 Guennadi Liakhovetski wrote: On Thu, 18 Apr 2013, Guennadi Liakhovetski wrote: Adding struct v4l2_subdev_platform_data to mt9p031's platform data

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-24 Thread javier Martin
wrote: [snip] diff --git a/drivers/media/video/mt9p031.c b/drivers/media/video/mt9p031.c new file mode 100644 index 000..e406b64 --- /dev/null +++ b/drivers/media/video/mt9p031.c [snip] +} + +static int mt9p031_power_on(struct mt9p031 *mt9p031) +{ +   int ret

Re: [PATCH v2 1/2] MT9P031: Add support for Aptina mt9p031 sensor.

2011-05-24 Thread Laurent Pinchart
Hi Javier, On Tuesday 24 May 2011 10:31:46 javier Martin wrote: On 23 May 2011 11:03, Laurent Pinchart wrote: On Saturday 21 May 2011 17:29:18 Guennadi Liakhovetski wrote: On Fri, 20 May 2011, Javier Martin wrote: [snip] diff --git a/drivers/media/video/mt9p031.c b/drivers/media

  1   2   3   4   5   6   7   8   9   10   >