2010/4/9 Andrew John Hughes <ahug...@redhat.com>: > 2010/4/9 Boris Dušek <boris.du...@gmail.com>: >> Hello, >> >> no one responded to my request for comments and possibly enlightment >> below, so I guess the right thing to do is that I just implement my >> proposed changes in a manner that I myself find "final" and submit the >> patch to the bugzilla directly, where the rest of the discussion will >> take place? >> > > This list does tend to be very quiet. The best way to elicit some > kind of response is to post a 'webrev' containing your changes: > > 1. Check out the tl forest of OpenJDK7: hg fclone > http://hg.openjdk.java.net/jdk7/tl > 2. Apply the patch to that tree and test it works > 3. Use the webrev tool > (http://blogs.sun.com/jcc/entry/webrev_script_updated) to generate a > webrev. > 4. Upload that somewhere. > > If you have issues with generating the webrev or posting it, then just > post the output of hg diff as a patch to the list and I can turn it > into a webrev for you easily enough. > >> Thanks, >> Boris >> >> 2010/3/30 Boris Dušek <boris.du...@gmail.com>: >>> Hello, >>> this is my first time contributing to Java or Sun (Oracle), so please >>> forgive me if I am doing something wrong. >>> >>> I am writing because I met an issue with JSignPdf app and my testing >>> certificates, which contain non-ASCII characters in my name (and so in CN >>> field) [1]. So I found it's bug 6522064, and after a bit of hesitation, >>>..... (snip) >>> Please let me know your comments and suggestions. >>> Thanks, >>> Boris Dušek >> > > Hope that helps, > -- > Andrew :-) > > Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > Support Free Java! > Contribute to GNU Classpath and the OpenJDK > http://www.gnu.org/software/classpath > http://openjdk.java.net > > PGP Key: 94EFD9D8 (http://subkeys.pgp.net) > Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 >
Also, including a reproducer testcase is a good idea so the effectiveness of the bug fix can be tested. -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
