On 11/17/10 12:41 PM, Sean Mullan wrote:
On 11/17/2010 02:34 PM, Mandy Chung wrote:
Hi Sean,

On 11/16/10 5:56 AM, Sean Mullan wrote:
http://cr.openjdk.java.net/~mullan/6995424/webrev.00/


Policy.java:
I was initially confused with the meaning of 'compatPolicy'. I thought
that when 'compatPolicy' is set to true, it means that the deprecated
javax.security.auth.Policy class or the legacy
com.sun.security.auth.PolicyFile is used for backward compatibility
support. It turns out that it's the reverse as it's set in line 241 and
295. Should it be renamed to 'useStandardPolicy' to make it clear?

I agree it is confusing but since that was the prior name I left it alone. What we are trying to find out is if the application is using a *custom* (one they wrote themselves and not com.sun.security.auth.PolicyFile) JAAS policy provider.

The flag essentially means: "if true, provide backwards compatibility for a deprecated, custom JAAS policy provider".


This helps.  Thanks.
I am open to changing the name but didn't feel that it was strictly necessary because I am not changing the meaning of it.

how about "isCustomProvider"? Your comment above describing the flag already explains it's for backward compatibility.

Mandy

Reply via email to