All the changes look good. I only have a couple of questions/comments:
1) How did you calculate the serialVersionUID for the classes that had omitted
this field? Ideally you want to calculate it on a previous version of the class,
for compatibility reasons. This is especially important for Serializable objects
that are exposed via public APIs.
2) Consider adding a comment explaining the "@SuppressWarnings("unchecked")"
annotations
--Sean
On 7/12/11 4:16 PM, Alexandre Boulgakov wrote:
> Since yesterday's webrev, I've changed some unchecked casts to use
> Class<T>.cast(Object) instead, per Dave's suggestion.
> Updated webrev: http://cr.openjdk.java.net/~jjg/7064075.1/
>
> Also, the original webrev was posted under the wrong bug ID, so it's
> been moved to http://cr.openjdk.java.net/~jjg/7064075/.
>
> Thanks,
> Sasha
>
> On 7/12/2011 1:03 PM, Brad Wetmore wrote:
>> Sean/Valerie/Max/Xuelei,
>>
>>> Hello Brad,
>>>
>>> Could you please review these changes?
>>
>> I'm swamped again, can one of you take a look at Sasha's changes?
>>
>> Brad
>>
>>
>>
>> On 7/11/2011 1:56 PM, Alexandre Boulgakov wrote:
>>> Hello Brad,
>>>
>>> Could you please review these changes?
>>>
>>> Bug detail: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7064075
>>> webrev: http://cr.openjdk.java.net/~jjg/7076075/
>>>
>>> Summary:
>>>
>>> * Small changes to Java files to remove most build warnings.
>>> * Small changes to relevant makefiles to prevent reintroduction of
>>> removed warnings.
>>>
>>>
>>> Thanks,
>>> Sasha Boulgakov
>>>
