Am 07.09.2011 19:51, schrieb Sean Mullan:
On 9/3/11 1:04 PM, Sebastian Sickelmann wrote:
Am 02.09.2011 21:58, schrieb Sean Mullan:
On 9/2/11 1:43 AM, Sebastian Sickelmann wrote:
Here is the updated webrev:
http://oss-patches.24.eu/openjdk8/NoSuchMechanismException/7011804_0/
Hmm, the main problem I have with this change is that the printStackTrace
methods will no longer print the stack trace of the cause because it will always
be null. That doesn't seem right to me, as it could be considered an
incompatible change, and it will make it harder to debug issues.
The printStackTrace in Throwable calls the overridden getCause().
Maybe we should add @Override to it.
Updated the webrev to:
http://oss-patches.24.eu/openjdk8/NoSuchMechanismException/7011804_1/
In that case, my main concern is addressed then. I would probably want someone
from our TCK team to also review it with respect to JSR 105 compatibility, so
I'll see if I can find someone.
Fine, that would be good.
But first, can you expand your webrev to include the other Exception classes in
javax.xml.crypto.**?
The new webrev is here:
http://oss-patches.24.eu/openjdk8/NoSuchMechanismException/7011804_2/
In some classes the initCause comment is misspelled as initCaus. What about a
test case, for example testing to make sure initCause throws an exception? Can
you write one?
Yes will fix this and create some tests.
Also, I have asked someone from the TCK team to look at this and he said he will
do that by Friday. It might require a CCC change because the behavior of
initCause is different. I am hoping it doesn't require a JSR 105 maintenance
revision though.
I hope so too. A JSR 105 maintenance revision is way to big for this
tiny "improvement"/change.
--Sean
-- Sebastian