Hi Xuelei

Why move the local variables to static fields?

The engineGetCertificates method is only synchronized on this but not the whole 
class, so there is a chance that the method is called by multiple threads at 
the same time. This means if you only use one static GetChainTrustManager 
field, its serverChain field can be modified by different threads.

-Max

On Nov 26, 2011, at 8:43 PM, Xuelei Fan wrote:

> webrev: http://cr.openjdk.java.net/~xuelei/7115524/webrev.00/
> 
> No new regression test, the current test,
> test/sun/security/tools/keytool/printssl.sh, has already been able to
> test the update.
> 
> Thanks,
> Xuelei

Reply via email to