On 12/20/2011 10:05 PM, Alan Bateman wrote:
On 20/12/2011 10:22, Weijun Wang wrote:
Hi Alan
Do you have time to look at this fix?
http://cr.openjdk.java.net/~weijun/7122169/webrev.01/
I study the test again and find out it's not the same as those BadKdc*
tests, where the port number must obey a pattern (n-th server on
n****). So there is no need to assign one before the server socket is
created. Also, it seems simply creating a server socket can simulate a
timeout, no need to call accept() in a separate thread explicitly.
I've tried the new test with JPRT and it runs fine.
Would it be simpler to use System.currentTimeMillis instead and that
would avoid needing the Windows check?
I'm not sure. The time consumed is from Socket::setSoTimeout(). Do you
know if it's connected to clock time (currentTimeMillis) or elapsed time
(nanoTime)?
Also while you are there, can the /timeout=40 be removed from the test
description?
Yes.
Thanks
Max
-Alan.
