Thank you, Dave and Weijun. The fix was integrated into JDK 8 as: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f0842ed897c3
Thanks, Xuelei On 4/27/2012 2:49 PM, Weijun Wang wrote: > Looks fine. > > It seems people normally put "static" before "final", but since there > are already 2 "final static" there, you're free to do anything. > > Thanks > Max > > On 04/27/2012 12:07 PM, Xuelei Fan wrote: >> On 4/27/2012 11:46 AM, David Schlosnagle wrote: >>> On Apr 26, 2012, at 10:07 PM, Xuelei Fan<xuelei....@oracle.com> wrote: >>> >>>> webrev: http://cr.openjdk.java.net/~xuelei/6996372/webrev.00/ >>> >>> It might be worthwhile to add a comment that both >>> disabledAlgorithmsMap and keySizeConstraintsMap are locked by the >>> disabledAlgorithmsMap instance. Also, is there any reason not to make >>> both of those static maps final? >>> >> Good suggestion. See the updated webrev: >> http://cr.openjdk.java.net/~xuelei/6996372/webrev.01/ >> >> Thanks, >> Xuelei >> >>> Thanks, >>> Dave >>