The fix is good, but I think you are over-commenting. Everyone seeing the synchronized keyword knows what it means. You can keep the new lines at 380-381.

Thanks
Max

On 05/04/2012 12:37 PM, Xuelei Fan wrote:
Hi,

Please review the synchronization issue in SSLContextImpl.

bug detail: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7153184
webrev: http://cr.openjdk.java.net/~xuelei/7153184/webrev.00/

No new regression test, simple fix and hard to reproduce the issue.

Thanks,
Xuelei

Reply via email to