Looks fine to me. Xuelei
On 6/15/2012 12:10 AM, Sean Mullan wrote: > Xuelei or Vinnie could you please review the following fix: > > http://cr.openjdk.java.net/~mullan/webrevs/7176326/ > > The bug has not been posted yet, so I've included the relevant details > below. It is a small regression introduced by my changes for JEP 124 > (6854712). > > Also, I have moved the existing zeroLengthPath test from the closed repo > (after removing a dependency on a proprietary cert), and enhanced it to > also test 7176326. > > Thanks, > Sean > ------------ > > The following SQE tets are failing after the changes in webrev > cr.openjdk.java.net/~mullan/webrevs/6854712_6637288_7126011/webrev.00 > have been merged > > CertPath/CertPathBuilderTest/KeyUsagePolicy/test11 > CertPath/CertPathBuilderTest/Misc/test101 > CertPathBuilderTest/Misc/test15 > CertPath/CertPathBuilderTest/Misc/test25 > CertPath/CertPathBuilderTest/Misc/test35 > CertPath/CertPathBuilderTest/Misc/test44 > CertPath/CertPathBuilderTest/Misc/test59 > CertPath/CertPathBuilderTest/Misc/test67 > CertPath/CertPathBuilderTest/Misc/test78 > CertPath/CertPathBuilderTest/Misc/test88 > > > Stacktrace > ----------- > java.lang.NullPointerException: subjectPublicKey must be non-null > at > java.security.cert.PKIXCertPathValidatorResult.<init>(PKIXCertPathValidatorResult.java:80) > > at > sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:215) > > at > sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:143) > > at > sun.security.provider.certpath.PKIXCertPathValidator.engineValidate(PKIXCertPathValidator.java:79) > > at > java.security.cert.CertPathValidator.validate(CertPathValidator.java:292) > at BuildCertPath.doBuild(BuildCertPath.java:414) > at BuildCertPath.main(BuildCertPath.java:139) > java.lang.NullPointerException: subjectPublicKey must be non-null > at > java.security.cert.PKIXCertPathValidatorResult.<init>(PKIXCertPathValidatorResult.java:80) > > at > sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:215) > > at > sun.security.provider.certpath.PKIXCertPathValidator.validate(PKIXCertPathValidator.java:143) > > at > sun.security.provider.certpath.PKIXCertPathValidator.engineValidate(PKIXCertPathValidator.java:79) > > at > java.security.cert.CertPathValidator.validate(CertPathValidator.java:292) > at BuildCertPath.doBuild(BuildCertPath.java:414) > at BuildCertPath.main(BuildCertPath.java:139) > > Entry 1 nithya.srinivasan [2012-06-12 16:46] > > Evaluation > > A regression was introduced as part of the JEP 124 changes (6854712). It > only causes an exception if you are validating a zero-length CertPath.
