The interop test is bi-directional. The new JDK needs to understand what older 
JDKs produce, vice versa. Therefore it must launch those older JDKs.

Thanks
Max



在 Jul 16, 2012,10:22 PM,Sean Mullan <sean.mul...@oracle.com> 写道:

> Hi Max,
> 
> The fix looks fine, but I am wondering if it is appropriate to require that 
> everyone that runs these tests must have these older JREs installed or 
> mounted for this test to pass. It seems like it would have been better to 
> pre-generate the serialized data and add them as test data files. I know 
> binary files are discouraged, but in this case it should be relatively easy 
> to reproduce the serialized forms if we ever need to, and other tests already 
> do this - for example see 
> test/java/security/BasicPermission/SerialVersion.java
> 
> --Sean
> 
> On 07/16/2012 09:18 AM, Weijun Wang wrote:
>> Hi
>> 
>> Please take a review at
>> 
>>   http://cr.openjdk.java.net/~weijun/7102106/webrev.00/
>> 
>> The new environment variable allows you to set an alternative path to
>> old JDK releases if the default /java/re/j2se is not what you want.
>> 
>> Thanks
>> Max
>> 
>> 
>> -------- Original Message --------
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7102106
>> 7102106: TEST_BUG: sun/security/util/Oid/S11N.sh should be modified
>> 
>> === *Description*
>> ============================================================
>> test used "/java/re" for latest binaries and failed because it is slowly
>> or not available from some russia lab machines (timeout)
>> 
>> test show wrong status "Passed" if /java/re is not available on machine
>> (reproducible on stt-52.ru.oracle.com)
>> 
>> latest binaries can be defined by env variable(s) and than lines:
>> 
>> OLDJAVA="
>>     /java/re/j2se/1.6.0/latest/binaries/${PF}
>>     /java/re/j2se/1.5.0/latest/binaries/${PF}
>>     /java/re/j2se/1.4.2/latest/binaries/${PF}
>> "
>> 
>> can be replaced, for example, on following lines:
>> OLDJAVA="
>>     ${JDK_LATEST_BASE_PATH}${FS}1.6.0${FS}latest${FS}binaries${FS}${PF}
>>     ${JDK_LATEST_BASE_PATH}${FS}1.5.0${FS}latest${FS}binaries${FS}${PF}
>>     ${JDK_LATEST_BASE_PATH}${FS}1.4.2${FS}latest${FS}binaries${FS}${PF}
>> "
>> 
>> JDK_LATEST_BASE_PATH can be set to /java/re by default and redefined to
>> available location if needed
>> 
>> test passed after relocate latest binaries at local Russia server and
>> change OLDJAVA
> 
> 

Reply via email to