On 21/09/2012 11:56, Weijun Wang wrote:
:
Overall it looks very good to me, the only thing that I'm not sure about
is the resources for keytool. As they are in sun.security.tools.keytool
it means they will all need to be included with the tool. If you wanted
a en_US vs. all split without splitting packages then it would meaning
moving them again.
So, maybe you should split the package?
If sun.security.tools.keytool is tiny then it might not matter, I'll
leave it to Steve to say whether it's worth it.
:
Is the change to sun/security/tools/keytool/autotest.sh just a merge
issue?
No, that was a new line so cannot be a merge issue.
Okay, just seems like it's not related to the change, maybe just added
to help diagnose a failure.
-Alan.