On 11/23/2012 12:54 PM, Xuelei Fan wrote:
On 11/23/2012 7:22 PM, Florian Weimer wrote:
On 11/22/2012 04:00 PM, Xuelei Fan wrote:
Hi Valerie, Max or Brad,

Can you review the update for JDK-7030966? It is the JSSE part of JEP
115.

webrev: http://cr.openjdk.java.net./~xuelei/7030966/webrev.00/
JEP 115: http://openjdk.java.net/jeps/115

In the update, I have not remove the debug synchronization.  I will
remove them before pushing the changeset.

Does this add a new memory allocation to every TLS record which is being
processed?

Not really.  We used to use large memory block (Record.maxRecordSize)
for every record.  The buffer size does not get changed.

I'm referring to this code in Authenticator.acquireAuthenticationBytes(). If I'm not mistaken, this is called for every record. Previously, the array was directly hashed, and after the refactoring, a copy is made and then hashed. Or am I missing something?

--
Florian Weimer / Red Hat Product Security Team

Reply via email to