On 11/28/2012 8:53 AM, Sean Mullan wrote:
Please review the following webrev which lazily initializes the
SecureRandom object used by the SunJCE provider.
In JDK 9, we want to load JCE providers with java.util.ServiceLoader
as part of the transition to modules. This can cause potential
recursive loading issues if the Sun provider for SecureRandom has not
been loaded yet (since providers are loaded in no specific order using
ServiceLoader). The fix is to lazily instantiate SunJCE.RANDOM. This
is a proactive fix that will smooth the transition to modules.
There is no regression test as this is a small refactoring that is
covered by existing tests. The bug has been tagged with the
noreg-cleanup label.
The bug is not up on bugs.sun.com yet.
bug : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004044
webrev: http://cr.openjdk.java.net/~mullan/webrevs/8004044/webrev.00
Looks good to me. This change has already been in the jigsaw repos [1]
for modules support. Thanks for including this change in jdk8 that will
help maintaining the delta between jdk8 and jigsaw to the minimum for
only the jigsaw-specific change.
Mandy
[1] http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/rev/bf6c3ddca9f9
