Yes there was some problem with the webrev generation , i had to
generate it too many times.
But i made sure all changes are present.
Thanks for taking a detailed look into this !!
rgds
mala
On 12/4/2012 10:52 AM, Xuelei Fan wrote:
Let's look at the history of the parent workspace;
1. You putback CR 7192392, Dec 2.
2. David undo the putback, Dec 3, 10:33
3. You bringover the workspace, Dec 3, 10:45
4. The you putback CR 7192392, Dec 3. 11:42
5. Java RE bringover the workspace, maybe for jar building.
The processes look right to me. But the webrev is incorrect. From item
4, it seems that you have putbacked the fix into the master workspace.
I looked more into a few history of the updated files. It seems that you
did the putback right.
OK, the webrev is incorrect. I guess that you did not generate a new
webrev before you integrate the chanegs. It's OK to me, but I need a
confirm in case of any mis-understanding from my side.
Thanks,
Xuelei
On 12/4/2012 12:51 PM, mala bankal wrote:
HI Andrew,
No it is not based on previous integration.
I brought over a fresh wses after Dave's rollback and made all changes
again. Made the changes and built the wses again.
It took me more time but i did it right.
Now before final integration i checked if changes are present in MASTER ws.
rgds
mala
On 12/4/2012 10:19 AM, Xuelei Fan wrote:
It seems that you webrev is based on your previous integration. I may
be wrong, but as my previous comment, I think as David has rollover your
previous integration, you need to rollover the changes in your local
workspace as well, or bringover new workspace, and then generate the
webrev, and then do a fresh integration. You webrev in the request make
me nervous that you properly cannot do the integration properly.
I would suggest:
1. backup the updated files.
2. bringover a new worksapce
3. merge the updated files into the new workspace
4. new webrev and ask for approval
5. integrate the change in the new workspace
PLEASE DON'T USE the old workspaces unless you know how to handle it
properly.
;-) I though you have accept my and Brad's comments, and added me as the
approve. I will add my name when you confirm to my above concerns.
Thanks,
Xuelei
On 12/4/2012 12:31 PM, [email protected] wrote:
[email protected]'s following code review request has been sent
to [email protected].
Please review the code before 12/8/12_8:29_PM.
If [email protected] can not meet the review timeline, please
contact
[email protected] to negotiate for an appropriate time-frame.
http://jpsesvr.us.oracle.com:8080/ctetools/html/Approve.jsp?index=4897
webrev:
http://jpsesvr.us.oracle.com:8080/ctetools/html/ViewDetail.jsp?index=4897
======================================
Escalation ID :
Escalation Synopsis :
Bug ID : JDK-7192392
Bug Synopsis : Better validation of client keys
Request Engineer : [email protected]
Code Reviewer : [email protected]
Parent Workspace :
http://jdksrc.sfbay.sun.com/hg/jdk5u/jdk5.0u39-dev/j2se
Child Workspace :
/net/nightsvr.sfbay/export5/users/mbankal/7192392/5.0u39/j2se
Platforms : Shared Code
Version : JDK5.0_u39
Fix information : Backport
Severity : normal - level 1
Submit Date : 12/3/12 8:29 PM
Problem and Fix Description :
Please see :
https://bug.oraclecorp.com/pls/bug/webbug_print.show?c_rptno=14474441
JSSE webrev:
http://v245-sus.ie.oracle.com/suspool/home/mala/7192392/5.0/JSSE/
JCE webrev:
http://v245-sus.ie.oracle.com/suspool/home/mala/7192392/5.0/JCE/
PKCS webrev :
http://v245-sus.ie.oracle.com/suspool/home/mala/7192392/5.0/PKCS/
removed KeyUtil.java from J2SE ws, it was introduced in JCE, JSSE.
PKCS wses to avoid dependency on ALT_BOOTDIR and build issues due to
the dependency.
Also updating RE built jar files
Modified source lists :
make/tools/crypto/jce/sunjce_provider.jar
make/tools/crypto/jsse/jsse.jar
make/tools/crypto/pkcs11/sunpkcs11.jar
Approve Info :
Putback info :
======================================
This message is autogenerated by code management tool.
