On 19/12/2012 21:35, Sean Mullan wrote:
For JEPs 161 and 162, we need to remove or deprecate undesirable
dependencies from the compact1 profile.
One of these is the dependency on
com.sun.security.auth.login.ConfigFile from
sun.security.provider.ConfigSpiFile.
The proposed fix moves the guts of the ConfigFile implementation to
sun.security.provider.ConfigSpiFile, and changes ConfigFile such that
it is simply a wrapper around ConfigSpiFile.
webrev: http://cr.openjdk.java.net/~mullan/webrevs/8005117/webrev.00/
Thanks for doing this, it's good to get this dependency fixed.
I've looked at the webrev and I can't see anything obviously wrong
(meaning it looks like you've transposed the code correctly). I think
once the tests pass then you are good to go.
Once thing in passing is that I see this code uses legacy
StreamTokenizer, might be good to get it moved to java.util.regex some day.
-Alan