Looks good. One comment. In PKCS7.java, can you document the new tSAPolicyId parameter in the javadoc.

--Sean

On 04/10/2013 10:06 PM, Weijun Wang wrote:
Hi Sean

Please review the code changes

    http://cr.openjdk.java.net/~weijun/8009636/webrev.00/

Here I add a new -tsapolicycd option to jarsigner and pass the value all
the way down to TSRequest. A new check inside
PKCS7::generateTimestampToken is added to confirm the responded policyID
is identical to the requested one (if provided). A test is also enhanced
to check this check.

Thanks
Max

Reply via email to