On 5/3/13 5:52 PM, Jason Uh wrote:
Hi Max,
On 05/03/2013 12:33 AM, Weijun Wang wrote:
Hi Jason
One question: why is this necessary in i18n.html and ChangeUI.html:
-<ol>
+<ol start="0">
Neither test mentions step #.
Using a zero-based list was just a stylistic choice, especially as Step
0 would be a case-specific ("If Windows...") step. I did reference it
later on. For example:
-and click "OK".<br><br>
+and click "OK".<br>
+If testing on Windows, use the temporary directory created in Step 0.
+(Example: Save as "C:\foo\tmp\ptool.test")<br><br>
Sorry I missed that.
Do you have a strong preference for me to change it back so that the
first step is numbered as "1."?
Not really. Choose whatever you prefer.
Thanks
Max
Otherwise, the changes look fine.
Thanks,
Jason
Thanks
Max
On 5/3/13 1:44 PM, Jason Uh wrote:
Could I please get a review for this fix for 8005922:
Edits to the manual test instructions for some policytool tests to
accommodate Windows-style paths.
Webrev: http://cr.openjdk.java.net/~juh/8005922/webrev.00/
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005922
Thanks,
Jason