DOMUtils.java
=============
It might be a little bit better to reuse the node local name checking with a new private static method.

Otherwise, looks fine.

A minor comment is a very personal preference. I may prefer to return null instead of throw exception in the new methods of class DOMUtils, when there is no such node. And the caller throw the exception instead. For example:
    public static Element getFirstChildElement(Node node,
        String localName) throws MarshalException


Xuelei

On 7/23/2013 9:05 PM, Sean Mullan wrote:
Xuelei,

Could you please review my fix for 8012288:

   http://cr.openjdk.java.net/~mullan/webrevs/8012288/webrev.00/

There is already an SQE test for this, so I have added the noreg-sqe label.

Thanks,
Sean

Reply via email to