Your fix looks good. On 1 Aug 2013, at 14:36, Xuelei Fan wrote:
> Hi, > > Please review this simple update. > > webrev: http://cr.openjdk.java.net/~xuelei/7127524/webrev.00/ > > The purpose of this fix is to remove the unnecessary serialVersionUID > definition in anonymous class. > > private static final SecretKey NULL_KEY = new SecretKey() { > - private static final long serialVersionUID = -8090049519656411362L; > // ... > } > > An anonymous class cannot make any guarantees about serialization > compatibility since has a compiler-generated, implementation-specific > name that may vary uncontrollably. It is nonsensical for an anonymous > class to define a serialVersionUID. > > No new regression test as it is a trivial update. > > Thanks, > Xuelei
