Re: [8] Request for Review: 8022461: Fix lint warnings in sun.security.{provider, rsa, x509}

[Weijun Wang]

Change looks fine.

Minor issue:
Extra parenthesis in 
src/share/classes/sun/security/rsa/RSAPublicKeyImpl.java:

+            byte[] keyArray =
+                (new DerValue(DerValue.tag_Sequence,
+                              out.toByteArray())).toByteArray();

One question:

In src/share/classes/sun/security/x509/X509Key.java, two fields are now 
not recommended:

    @Deprecated
    protected byte[] key = null;

    /*
     * The number of bits unused in the last byte of the key.
     * Added to keep the byte[] key form consistent with the BitArray
     * form. Can de deleted when byte[] key is deleted.
     */
    private int unusedBits = 0;

I understand that key should be marked @Deprecated because it's 
protected and therefore part of (although private) API, but what about 
unusedBits? Is it better to also mark it @Deprecated?

Thanks
Max

On 8/7/13 7:51 AM, Joe Darcy wrote:
Hi Jason,

Looks fine to me, but a security reviewer should approve as well.

Thanks,

-Joe

On 08/06/2013 04:46 PM, Jason Uh wrote:
Joe, Sean,

Could I please get a review of this changeset? This change fixes
deprecation warnings in:
 sun.security.provider
 sun.security.rsa
 sun.security.x509

In sun.security.provider and sun.security.rsa, I change the use of
sun.security.x509.X509Key's key bytes to the BitArray form of the key.

Webrev: http://cr.openjdk.java.net/~juh/8022461/webrev.00/

Thanks,
Jason