Looks fine. A minor suggestion is that the code in equals could be simplified a little:

    if (! (other instanceof KerberosPrincipal)) {
        return false;
    }
    String myFullName = getName();
    String otherFullName = ((KerberosPrincipal) other).getName();
    return myFullName.equals(otherFullName);

--Sean

On 08/25/2013 11:42 PM, Weijun Wang wrote:
Hi Sean

Please look at the webrev at

   http://cr.openjdk.java.net/~weijun/8015669/webrev.00/

A new regression test is added.

Thanks
Max

Reply via email to