Hi All,

Please help review a simple change towards the testcase, TestProviderLeak.java.

In the call of SecretKeyFactory.getInstance(), it will try to access files under temporary directory by calling File.list() method. And this list() method may consume a lot of memory if there are large amount of files inside. In such case, it will cause OutOfMemory error and fail the test. As the contents in the tmp directory vary at different time and on different machines, it leads to the fragility of this test. In the change, it moves eatupMemory() method close to the testing iteration to avoid the memory consumption in non-testing codes.

Bug: https://bugs.openjdk.java.net/browse/JDK-8027624
Webrev: http://cr.openjdk.java.net/~dxu/8027624/webrev/ <http://cr.openjdk.java.net/%7Edxu/8027624/webrev/>

Thanks,

-Dan

Reply via email to