Thanks Alan. In this case, each call to GetByteArrayRegion is
preceded by a call to GetArrayLength so passing an array index
that is out of bounds cannot occur.
On 04/02/2014 16:39, Alan Bateman wrote:
On 04/02/2014 16:31, Vincent Ryan wrote:
:
Please review this patch for better handling of JNI pending exceptions
in the ECC native code:
Webrev: http://cr.openjdk.java.net/~vinnie/8028727/webrev.00/
The patch examines the return code from JNI calls to check whether an
exception is already pending. If so then it cleans up and returns.
This looks to good, I just wonder about the calls GetByteArrayRegion as
they can potentially fail with NULL/ArrayIndexOutOfBoundsException. It
would be a bug if we pass indexes that are out of range but it might be
worth checking those too.
-Alan
