Hi, Max,
Just noticed that there is a JNIEnv->NewObject call on line 378. It
looks like we have to check pending exception there also? This call is
inside a while loop...
Rest looks fine.
Thanks,
Valerie
On 02/13/14 17:49, Wang Weijun wrote:
Updated webrev at
http://cr.openjdk.java.net/~weijun/8034033/webrev.01/
Thanks
Max
On Feb 13, 2014, at 8:56, Wang Weijun<weijun.w...@oracle.com> wrote:
On Feb 13, 2014, at 8:48, Valerie (Yu-Ching) Peng<valerie.p...@oracle.com>
wrote:
Max,
Changes look fine.
However, I noticed some calls which may throw exceptions but no check is added,
e.g.
593 (*env)->SetObjectArrayElement(env, address_list, index, address);
That's in a while loop. Maybe parfait does not realize SetByteArrayRegion could
be called after SetObjectArrayElement?
BTW, I noticed there are several existing calls to ExceptionOccurred(...) which
can be replaced with ExceptionCheck(...) calls which won't create local
references to the exception object.
I see. So ExceptionCheck is just a return-void version of ExceptionOccurred.
I'll create another webrev.
Thanks
Max
Thanks,
Valerie
On 02/11/14 04:27, Wang Weijun wrote:
Hi All
I didn't attend the parfait day last week, but a new one is coming. Please
review my fix at
http://cr.openjdk.java.net/~weijun/8034033/webrev.00/
Thanks
Max
