Change looks fine, so does the closed repo. Hopefully you've already run both the automatic and manual tests.
Thanks Max On Mar 3, 2014, at 21:58, Xuelei Fan <xuelei....@oracle.com> wrote: > Just as you see, webrev is ugly. Here is the export changeset: > http://cr.openjdk.java.net/~xuelei/8032473/update.export > > "hg import" should work. From the changeset, we can see the content > changes in renames files. > > Xuelei > > On 3/3/2014 9:38 PM, Wang Weijun wrote: >> Hi Xuelei >> >> Yes it's quite difficult to read the actual webrev so instead I try to apply >> jdk.patch to my repo and see what happens. The patch file cannot remove the >> old files so I cannot be sure the cleanup is clean. Is it possible you >> recreate the webrev with a changeset (instead of jdk.patch). I think it can >> be created with a plain webrev call without using the -r option. >> >> I just want to confirm: >> >> 1. No more file in old directory >> 2. JPRT runs fine >> 3. Number of test running not changed >> >> Also, the webrev shows no diff and it looks each file just have a new name >> and its content unchanged, but we know there are at least path to store >> changes. >> >> --Max >> >> On Mar 3, 2014, at 19:46, Xuelei Fan <xuelei....@oracle.com> wrote: >> >>> webrev: http://cr.openjdk.java.net/~xuelei/8032473/webrev.00/ >>> >>> On 3/3/2014 1:54 PM, Wang Weijun wrote: >>>> As Brad mentioned in the comment, do you need to update the >>>> test/TEST.groups file? >>>> >>> Yes. >>> >>>> Although not friendly to read, you do have a webrev somewhere? >>>> >>> Just made it ready. Please review the update. >>> >>> Thanks, >>> Xuelei >>> >>>> Thanks >>>> Max >>>> >>> >> >
